chore: use fixture vs WebSocketServer
#2567
Merged
+34
−37
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ws.server.connect.browser.test.ts#2557Motivation
There's something clearly off with how the
WebSocketServerutility integrates with the Playwright tests:To make sure that the server is managed properly, I'm moving it to a fixture. I hope this helps in preventing Fastify from failing here.