Skip to content

Sort with defaults #215

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mthadley merged 5 commits into from
Feb 15, 2023
Merged

Sort with defaults #215

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
3432aa3
Sort with defaults
ianobermiller Jan 19, 2023
8b25376
Fix crash on empty array value
ianobermiller Jan 19, 2023
c900fc7
Flip check so that we don't bail on empty array elements
ianobermiller Jan 19, 2023
b0ca63b
Address code review feedback
ianobermiller Jan 25, 2023
211af2a
Add test for simple aliasing and referencing
ianobermiller Jan 25, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Add test for simple aliasing and referencing
  • Loading branch information
@ianobermiller
ianobermiller committed Jan 25, 2023
commit 211af2ab7c664d093a12394d65a54f7c0e4b299b
1 change: 1 addition & 0 deletions tests/lib/rules/sort-destructure-keys.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,6 +149,7 @@ function testsWithParser(parser, parserOptions = {}) {
`const {c, b, d: { e }, a = e} = someObj;`,
`const {c, b, d: [e], a = e} = someObj;`,
`const {c, b, d: [, e], a = e} = someObj;`,
`const {c, b, d: e, a = e} = someObj;`,
],
invalid: [
{
Expand Down