Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions .github/workflows/main.yml
Original file line number Diff line number Diff line change
Expand Up @@ -5,15 +5,22 @@ jobs:
runs-on: ubuntu-latest
strategy:
matrix:
node: [12, 14, 16, 18, 20]
name: Test with Node ${{ matrix.node }}
include:
- node: 20
eslint: 9
- node: 18
eslint: 8
- node: 12
eslint: 5
name: node@${{ matrix.node }} and eslint@${{ matrix.eslint }}
steps:
- uses: actions/checkout@v3
- name: Setup node
uses: actions/setup-node@v3
with:
node-version: ${{ matrix.node }}
- run: npm ci
- run: npm install eslint@${{ matrix.eslint }}
- run: npm test

format:
Expand Down
7 changes: 4 additions & 3 deletions lib/rules/sort-destructure-keys.js
Original file line number Diff line number Diff line change
Expand Up @@ -217,9 +217,10 @@ module.exports = {

return {
ObjectPattern(objectPatternNode) {
const scope = sourceCode.getScope
? sourceCode.getScope(objectPatternNode)
: context.getScope();
const scope =
sourceCode && sourceCode.getScope
? sourceCode.getScope(objectPatternNode)
: context.getScope();

/*
* If the node is more complex than just basic destructuring
Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
"format": "prettier --write \"{lib,tests}/**/*.js\""
},
"peerDependencies": {
"eslint": "3 - 9"
"eslint": "5 - 9"
},
"dependencies": {
"natural-compare-lite": "^1.4.0"
Expand Down
38 changes: 30 additions & 8 deletions tests/lib/rules/sort-destructure-keys.js
Original file line number Diff line number Diff line change
@@ -1,5 +1,16 @@
const assert = require("assert");
const rule = require("../../../lib/rules/sort-destructure-keys");
const RuleTester = require("eslint").RuleTester;
const eslint = require("eslint");

function eslintMajorVersion() {
const version = eslint.CLIEngine
? eslint.CLIEngine.version
: eslint.ESLint.version;
const match = version.match(/^(?<major>\d+)\.\d+\.\d+$/);
assert.ok(match, "ESLint `version` must have a major version number.");

return Number(match.groups.major);
}

function msg(second, first) {
return {
Expand All @@ -14,13 +25,24 @@ function just(...args) {

function testsWithParser(parser, parserOptions = {}) {
describe(`with parser: ${parser}`, () => {
const ruleTester = new RuleTester({
parser: require.resolve(parser),
parserOptions: {
...parserOptions,
ecmaVersion: 2018,
},
});
parserOptions = {
...parserOptions,
ecmaVersion: 2018,
};

const ruleTester = new eslint.RuleTester(
eslintMajorVersion() >= 9
? {
languageOptions: {
parser: require(parser),
parserOptions,
},
}
: {
parser: require.resolve(parser),
parserOptions,
},
);

const testsFor = (name, ...args) => ruleTester.run(name, rule, ...args);

Expand Down