This repository was archived by the owner on Dec 3, 2019. It is now read-only.
Check if generated file was modified before uploading to S3 #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… unmodified. Check if generated file was modified before uploading to S3. Refactoring : #_s3render_path now only responsible for checking etags, generating paths and generating static files; #_upload_to_s3 responsible for actual uploading.
Owner
|
Works as expected and results in super fast re-deploys when only updating certain files. This. Is. Awesome. Thanks! |
mtigas
added a commit
that referenced
this pull request
Jul 5, 2012
Check if generated file was modified before uploading to S3
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think it's kinda wasteful to upload all files to S3 on every ./manage staticsitegen run, so I refactored _s3render_path to check the md5 hash against the key's etag (if it exists).
Boto's #compute_md5 method expects a file object, so the function creates an in-memory file using cStringIO, a faster StringIO. If you find any problems, I could switch it for an in-disk NamedRemporaryFile.