[Menu, Select, Dialog] Use internal backdrop for pointer modality#1161
Merged
Conversation
atomiks
added
component: select
Netlify deploy preview |
mnajdova
reviewed
Dec 18, 2024
mnajdova
left a comment
mnajdova
left a comment
Member
There was a problem hiding this comment.
The direction makes sense to me. Just to make sure, will we still have the *Dialog exported components so people can style their backdrops?
Contributor
Author
The |
Member
Makes total sense, this is what I wanted to confirm 👌 |
atomiks
force-pushed
the
fix/internal-backdrop
branch
from
d4ceac9 to
f832acd
Compare
mnajdova
reviewed
Dec 23, 2024
mnajdova
approved these changes
Dec 23, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1119
Also looks to close #1107 demo
pointer-events: noneon "outside" elements causes perf issues in Firefox and Safari, degrading increasingly worse as the page size increases.pointer-events: nonewith anauto"hole" on the popup isn't feasible due to interop issues with other popups (extensions, other libraries or custom elements) as they will be unusable since they don't know to specifyauto.The main issue with an internal backdrop is
z-indexlayering. With Set up portals in our docs, this issue is essentially gone as the portaled backdrop will always cover the isolated root content.