[Dialog, AlertDialog] Fix the nesting of different dialogs#1167
Merged
Conversation
mnajdova
added
component: alert dialog
1 task
Netlify deploy preview |
mnajdova
commented
Dec 18, 2024
Signed-off-by: Marija Najdova <mnajdova@gmail.com>
mnajdova
requested review from
atomiks,
colmtuite and
michaldudak
as code owners
atomiks
approved these changes
Dec 19, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1165
The idea is to use common context between all dialog components. I extracted only the common things inside this context.