[Popover, Tooltip] Fix PopoverTrigger and TooltipTrigger prop types#1209
Merged
Conversation
okmr-d
requested review from
atomiks,
colmtuite and
michaldudak
as code owners
Netlify deploy preview |
atomiks
reviewed
Dec 21, 2024
| } | ||
|
|
||
| export interface Props extends BaseUIComponentProps<any, State> {} | ||
| export interface Props extends BaseUIComponentProps<'button', State> {} |
Contributor
There was a problem hiding this comment.
Tooltips can go on any type of element, not just buttons. It should at least have the props: GenericHTMLProps type instead of props: any though
Contributor
Author
There was a problem hiding this comment.
I don't know how to fix it cleanly, I have reverted TooltipTrigger fix.
Contributor
There was a problem hiding this comment.
Thanks for pointing this out. I've made an extra PR here: #1213
1 task
atomiks
approved these changes
Dec 23, 2024
Member
|
It's a great first pull request on Base UI @okmr-d! Thank you for working on it 👌 |
zannager
added
component: tooltip
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix wrong prop types.
