[dialog] Remove useFloating call from the Popup#1300
Merged
michaldudak merged 1 commit intoJan 8, 2025
Conversation
michaldudak
added
component: alert dialog
Netlify deploy preview |
atomiks
approved these changes
Jan 8, 2025
oliviertassinari
changed the title
useFloating call from the PopupuseFloating call from the Popup
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removed the
useFloatingcall from the Dialog.Previously, it was required by FloatingFocusManager, but with the recent change in Floating UI, it is no longer the case, and we can avoid needlessly importing positioning logic.
Part of #1246