Skip to content

[RadioGroup] Convert to a function component #14964

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
oliviertassinari merged 4 commits into from
Mar 22, 2019
Merged

[RadioGroup] Convert to a function component #14964

oliviertassinari merged 4 commits into from
Mar 22, 2019

Conversation

@joshwooding
Copy link
Collaborator

@joshwooding joshwooding commented Mar 19, 2019

Todo

  • Convert RadioGroup to function component
  • Forward ref to RadioGroup
  • Provide focus via actions prop for consistency
  • Adjust tests and test ref is forwarded

@joshwooding joshwooding added breaking change Introduces changes that are not backward compatible. scope: radio Changes related to the radio. labels Mar 19, 2019
@mui-pr-bot
Copy link

mui-pr-bot commented Mar 19, 2019 •
edited
Loading

Details of bundle changes.

Comparing: 7e64283...34af883

bundle parsed diff gzip diff prev parsed current parsed prev gzip current gzip
@material-ui/core -0.06% -0.10% 353,435 353,236 90,549 90,462
@material-ui/core/Paper -0.01% -0.02% 68,636 68,626 19,982 19,978
@material-ui/core/Paper.esm -0.01% -0.01% 62,366 62,358 19,075 19,073
@material-ui/core/Popper +0.01% 🔺 +0.03% 🔺 30,457 30,460 10,525 10,528
@material-ui/core/styles/createMuiTheme -0.03% -0.02% 17,390 17,384 5,729 5,728
@material-ui/core/useMediaQuery 0.00% +0.10% 🔺 2,469 2,469 1,036 1,037
@material-ui/lab 0.00% -0.01% 152,179 152,181 44,538 44,534
@material-ui/styles -0.01% -0.03% 53,841 53,837 15,621 15,616
@material-ui/system -0.02% -0.11% 17,141 17,138 4,524 4,519
Button -0.01% -0.00% 90,925 90,918 26,971 26,970
Modal -0.00% +0.01% 🔺 84,715 84,712 25,260 25,262
colorManipulator -0.06% -0.08% 3,234 3,232 1,301 1,300
docs.landing 0.00% 0.00% 51,843 51,843 11,349 11,349
docs.main 0.00% 0.00% 649,387 649,387 201,472 201,472
packages/material-ui/build/umd/material-ui.production.min.js -0.04% +0.02% 🔺 302,411 302,275 83,725 83,744

Generated by 🚫 dangerJS against 34af883

@joshwooding joshwooding added the type: new feature Expand the scope of the product to solve a new problem. label Mar 19, 2019
oliviertassinari
oliviertassinari reviewed Mar 19, 2019
View reviewed changes
oliviertassinari
oliviertassinari reviewed Mar 19, 2019
View reviewed changes
eps1lon
eps1lon reviewed Mar 20, 2019
View reviewed changes
eps1lon
eps1lon reviewed Mar 20, 2019
View reviewed changes
@joshwooding joshwooding requested a review from eps1lon March 21, 2019 08:27
@oliviertassinari oliviertassinari merged commit 8f359dd into mui:next Mar 22, 2019
@oliviertassinari
Copy link
Member

oliviertassinari commented Mar 22, 2019

Nice :)

@joshwooding joshwooding deleted the radio-group-hooks branch March 22, 2019 22:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@oliviertassinari oliviertassinari oliviertassinari approved these changes

@eps1lon eps1lon Awaiting requested review from eps1lon

Assignees

No one assigned

Labels

breaking change Introduces changes that are not backward compatible. scope: radio Changes related to the radio. type: new feature Expand the scope of the product to solve a new problem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@joshwooding @mui-pr-bot @oliviertassinari @eps1lon