Skip to content

[TextField] Fix long label scrollbar #20535

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
oliviertassinari merged 2 commits into from
Apr 13, 2020
Merged

[TextField] Fix long label scrollbar #20535

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c9afe78
Bug fixed
igor-repeatmd Apr 13, 2020
cfbf20d
Update NotchedOutline.js
oliviertassinari Apr 13, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/material-ui/src/OutlinedInput/NotchedOutline.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,7 @@ export const styles = (theme) => {
paddingLeft: 5,
paddingRight: 5,
display: 'inline-block',
whiteSpace: 'nowrap',
Copy link
Member

@oliviertassinari oliviertassinari Apr 13, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for exploring this option, I hadn't thought about it. Unfortunately, I think that we should stick with the overflow hidden. While the nowrap solves the vertical scrollbar, it creates a horizontal on. Also, fundamentally, I think that the label and span should style should be as close as possible.

Capture d’écran 2020-04-13 à 21 00 32

},
},
/* Styles applied to the legend element is notched. */
Expand Down