Skip to content

[ClickAwayListener] Fix support of leading edge #20647

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
oliviertassinari merged 2 commits into from
Apr 20, 2020
Merged

[ClickAwayListener] Fix support of leading edge #20647

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c981fe7
[ClickAwayListener] Support leading edge
oliviertassinari Apr 19, 2020
3b6195d
Sebsatian review
oliviertassinari Apr 19, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Sebsatian review
  • Loading branch information
@oliviertassinari
oliviertassinari committed Apr 19, 2020
commit 3b6195de9ab0243fc7760cd0c1dc9a763dd62fa5
2 changes: 2 additions & 0 deletions docs/src/pages/components/click-away-listener/click-away-listener.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,3 +31,5 @@ By default, the component responds to the trailing events (click + touch end).
However, you can configure it to respond to the leading events (mouse down + touch start).

{{"demo": "pages/components/click-away-listener/LeadingClickAway.js"}}

> ⚠️ In this mode, only interactions on the scrollbar of the document is ignored.
4 changes: 2 additions & 2 deletions packages/material-ui/src/ClickAwayListener/ClickAwayListener.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ function mapEventPropToEvent(eventProp) {
return eventProp.substring(2).toLowerCase();
}

function hasClickedScrollbar(event) {
function clickedRootScrollbar(event) {
return (
document.documentElement.clientWidth < event.clientX ||
document.documentElement.clientHeight < event.clientY
Expand Down Expand Up @@ -63,7 +63,7 @@ function ClickAwayListener(props) {
// 1. IE 11 support, which trigger the handleClickAway even after the unbind
// 2. The child might render null.
// 3. Behave like a blur listener.
if (!mountedRef.current || !nodeRef.current || hasClickedScrollbar(event)) {
if (!mountedRef.current || !nodeRef.current || clickedRootScrollbar(event)) {
return;
}

Expand Down