Skip to content

[code-infra] Don't require noreferrer on target link #40447

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
oliviertassinari merged 1 commit into from
Jan 7, 2024
Merged

[code-infra] Don't require noreferrer on target link #40447

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion .eslintrc.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -163,6 +163,9 @@ module.exports = {
'react/state-in-constructor': 'off',
// stylistic opinion. For conditional assignment we want it outside, otherwise as static
'react/static-property-placement': 'off',
// noopener is enough, no IE 11 support
// https://github.com/jsx-eslint/eslint-plugin-react/blob/master/docs/rules/jsx-no-target-blank.md#rule-options
'react/jsx-no-target-blank': ['error', { allowReferrer: true }],

'no-restricted-syntax': [
// See https://github.com/eslint/eslint/issues/9192 for why it's needed
Expand Down Expand Up @@ -209,7 +212,6 @@ module.exports = {
// matching the pattern of the test runner
'*.test.mjs',
'*.test.js',
'*.test.mjs',
'*.test.ts',
'*.test.tsx',
],
Expand Down
10 changes: 5 additions & 5 deletions apps/zero-runtime-next-app/src/app/page.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -170,7 +170,7 @@ export default function Home() {
<a
href="https://vercel.com?utm_source=create-next-app&utm_medium=appdir-template&utm_campaign=create-next-app"
target="_blank"
rel="noopener noreferrer"
rel="noopener"
>
By{' '}
<Image
Expand Down Expand Up @@ -200,7 +200,7 @@ export default function Home() {
<Card
href="https://nextjs.org/docs?utm_source=create-next-app&utm_medium=appdir-template&utm_campaign=create-next-app"
target="_blank"
rel="noopener noreferrer"
rel="noopener"
>
<h2>
Docs <span>-&gt;</span>
Expand All @@ -211,7 +211,7 @@ export default function Home() {
<Card
href="https://nextjs.org/learn?utm_source=create-next-app&utm_medium=appdir-template&utm_campaign=create-next-app"
target="_blank"
rel="noopener noreferrer"
rel="noopener"
>
<h2>
Learn <span>-&gt;</span>
Expand All @@ -222,15 +222,15 @@ export default function Home() {
<Card
href="https://vercel.com/templates?framework=next.js&utm_source=create-next-app&utm_medium=appdir-template&utm_campaign=create-next-app"
target="_blank"
rel="noopener noreferrer"
rel="noopener"
>
<h2>
Templates <span>-&gt;</span>
</h2>
<p>Explore the Next.js 13 playground.</p>
</Card>

<Card as={Link} href="/slider" rel="noopener noreferrer">
<Card as={Link} href="/slider" rel="noopener">
<h2>
Checkout Slider <span>-&gt;</span>
</h2>
Expand Down
2 changes: 1 addition & 1 deletion docs/data/joy/customization/overriding-component-structure/OverridingRootSlot.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ export default function OverridingRootSlot() {
component="a"
href="https://mui.com/about/"
target="_blank"
rel="noopener noreferrer"
rel="noopener"
>
About us
</Button>
Expand Down
2 changes: 1 addition & 1 deletion docs/data/joy/customization/overriding-component-structure/OverridingRootSlot.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ export default function OverridingRootSlot() {
component="a"
href="https://mui.com/about/"
target="_blank"
rel="noopener noreferrer"
rel="noopener"
>
About us
</Button>
Expand Down
2 changes: 1 addition & 1 deletion docs/data/joy/customization/overriding-component-structure/OverridingRootSlot.tsx.preview
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
component="a"
href="https://mui.com/about/"
target="_blank"
rel="noopener noreferrer"
rel="noopener"
>
About us
</Button>
4 changes: 2 additions & 2 deletions docs/data/joy/getting-started/templates/TemplateCollection.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -216,7 +216,7 @@ export default function TemplateCollection() {
<Link
href={template.author.link}
target="_blank"
rel="noopener noreferrer"
rel="noopener nofollow"
>
<b>{template.author.name}</b>
</Link>
Expand All @@ -241,7 +241,7 @@ export default function TemplateCollection() {
<Link
href={template.design.link}
target="_blank"
rel="noopener noreferrer nofollow"
rel="noopener nofollow"
>
<b>{template.design.name}</b>
</Link>
Expand Down
18 changes: 9 additions & 9 deletions docs/data/system/flexbox/flexbox.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ If you are **new to or unfamiliar with flexbox**, we encourage you to read this
### flex-direction

For more information please see
<a href="https://developer.mozilla.org/en-US/docs/Web/CSS/flex-direction" target="_blank" rel="noopener noreferrer">flex-direction</a>
<a href="https://developer.mozilla.org/en-US/docs/Web/CSS/flex-direction" target="_blank" rel="noopener">flex-direction</a>
on MDN.

{{"demo": "FlexDirection.js", "defaultCodeOpen": false, "bg": true}}
Expand All @@ -33,7 +33,7 @@ on MDN.
### flex-wrap

For more information please see
<a href="https://developer.mozilla.org/en-US/docs/Web/CSS/flex-wrap" target="_blank" rel="noopener noreferrer">flex-wrap</a>
<a href="https://developer.mozilla.org/en-US/docs/Web/CSS/flex-wrap" target="_blank" rel="noopener">flex-wrap</a>
on MDN.

{{"demo": "FlexWrap.js", "defaultCodeOpen": false, "bg": true}}
Expand All @@ -47,7 +47,7 @@ on MDN.
### justify-content

For more information please see
<a href="https://developer.mozilla.org/en-US/docs/Web/CSS/justify-content" target="_blank" rel="noopener noreferrer">justify-content</a>
<a href="https://developer.mozilla.org/en-US/docs/Web/CSS/justify-content" target="_blank" rel="noopener">justify-content</a>
on MDN.

{{"demo": "JustifyContent.js", "defaultCodeOpen": false, "bg": true}}
Expand All @@ -64,7 +64,7 @@ on MDN.
### align-items

For more information please see
<a href="https://developer.mozilla.org/en-US/docs/Web/CSS/align-items" target="_blank" rel="noopener noreferrer">align-items</a>
<a href="https://developer.mozilla.org/en-US/docs/Web/CSS/align-items" target="_blank" rel="noopener">align-items</a>
on MDN.

{{"demo": "AlignItems.js", "defaultCodeOpen": false, "bg": true}}
Expand All @@ -80,7 +80,7 @@ on MDN.
### align-content

For more information please see
<a href="https://developer.mozilla.org/en-US/docs/Web/CSS/align-content" target="_blank" rel="noopener noreferrer">align-content</a>
<a href="https://developer.mozilla.org/en-US/docs/Web/CSS/align-content" target="_blank" rel="noopener">align-content</a>
on MDN.

{{"demo": "AlignContent.js", "defaultCodeOpen": false, "bg": true}}
Expand All @@ -99,7 +99,7 @@ on MDN.
### order

For more information please see
<a href="https://developer.mozilla.org/en-US/docs/Web/CSS/order" target="_blank" rel="noopener noreferrer">order</a>
<a href="https://developer.mozilla.org/en-US/docs/Web/CSS/order" target="_blank" rel="noopener">order</a>
on MDN.

{{"demo": "Order.js", "defaultCodeOpen": false, "bg": true}}
Expand All @@ -113,7 +113,7 @@ on MDN.
### flex-grow

For more information please see
<a href="https://developer.mozilla.org/en-US/docs/Web/CSS/flex-grow" target="_blank" rel="noopener noreferrer">flex-grow</a>
<a href="https://developer.mozilla.org/en-US/docs/Web/CSS/flex-grow" target="_blank" rel="noopener">flex-grow</a>
on MDN.

{{"demo": "FlexGrow.js", "defaultCodeOpen": false, "bg": true}}
Expand All @@ -127,7 +127,7 @@ on MDN.
### flex-shrink

For more information please see
<a href="https://developer.mozilla.org/en-US/docs/Web/CSS/flex-shrink" target="_blank" rel="noopener noreferrer">flex-shrink</a>
<a href="https://developer.mozilla.org/en-US/docs/Web/CSS/flex-shrink" target="_blank" rel="noopener">flex-shrink</a>
on MDN.

{{"demo": "FlexShrink.js", "defaultCodeOpen": false, "bg": true}}
Expand All @@ -141,7 +141,7 @@ on MDN.
### align-self

For more information please see
<a href="https://developer.mozilla.org/en-US/docs/Web/CSS/align-self" target="_blank" rel="noopener noreferrer">align-self</a>
<a href="https://developer.mozilla.org/en-US/docs/Web/CSS/align-self" target="_blank" rel="noopener">align-self</a>
on MDN.

{{"demo": "AlignSelf.js", "defaultCodeOpen": false, "bg": true}}
Expand Down
6 changes: 3 additions & 3 deletions docs/src/components/about/Team.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -148,7 +148,7 @@ function Person(props: Profile & { sx?: PaperProps['sx'] }) {
component="a"
href={`https://github.com/${props.github}`}
target="_blank"
rel="noreferrer noopener"
rel="noopener"
>
<GitHubIcon fontSize="small" sx={{ color: 'grey.500' }} />
</IconButton>
Expand All @@ -159,7 +159,7 @@ function Person(props: Profile & { sx?: PaperProps['sx'] }) {
component="a"
href={`https://twitter.com/${props.twitter}`}
target="_blank"
rel="noreferrer noopener"
rel="noopener"
>
<XIcon fontSize="small" sx={{ color: 'grey.500' }} />
</IconButton>
Expand All @@ -170,7 +170,7 @@ function Person(props: Profile & { sx?: PaperProps['sx'] }) {
component="a"
href={`https://www.linkedin.com/${props.linkedin}`}
target="_blank"
rel="noreferrer noopener"
rel="noopener"
>
<LinkedInIcon fontSize="small" sx={{ color: 'grey.500' }} />
</IconButton>
Expand Down
4 changes: 2 additions & 2 deletions docs/src/components/home/DiamondSponsors.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@ export default function DiamondSponsors() {
component="a"
href="mailto:[email protected]"
target="_blank"
rel="noopener noreferrer"
rel="noopener"
color="primary"
sx={(theme) => ({
mr: 2,
Expand All @@ -91,7 +91,7 @@ export default function DiamondSponsors() {
</Typography>
<Typography variant="body2" color="text.secondary">
To join us, contact us at{' '}
<Link href="mailto:[email protected]" target="_blank" rel="noopener noreferrer">
<Link href="mailto:[email protected]" target="_blank" rel="noopener">
[email protected]
</Link>{' '}
for pre-approval.
Expand Down
4 changes: 2 additions & 2 deletions docs/src/components/home/GoldSponsors.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,7 +118,7 @@ export default function GoldSponsors() {
component="a"
href={ROUTES.goldSponsor}
target="_blank"
rel="noopener noreferrer"
rel="noopener"
color="primary"
sx={(theme) => ({
mr: 2,
Expand All @@ -137,7 +137,7 @@ export default function GoldSponsors() {
</Typography>
<Typography variant="body2" color="text.secondary">
Find out how{' '}
<Link href={ROUTES.goldSponsor} target="_blank" rel="noopener noreferrer">
<Link href={ROUTES.goldSponsor} target="_blank" rel="noopener">
you can support MUI.
</Link>
</Typography>
Expand Down
16 changes: 8 additions & 8 deletions docs/src/layouts/AppFooter.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,7 +137,7 @@ export default function AppFooter(props: AppFooterProps) {
</Box>
<Link href={ROUTES.support}>Support</Link>
<Link href={ROUTES.privacyPolicy}>Privacy policy</Link>
<Link target="_blank" rel="noopener noreferrer" href="mailto:[email protected]">
<Link target="_blank" rel="noopener" href="mailto:[email protected]">
Contact us
</Link>
</Box>
Expand All @@ -157,7 +157,7 @@ export default function AppFooter(props: AppFooterProps) {
<Stack spacing={1} direction="row" flexWrap="wrap" useFlexGap>
<IconButton
target="_blank"
rel="noopener noreferrer"
rel="noopener"
href="https://github.com/mui"
aria-label="github"
title="GitHub"
Expand All @@ -167,7 +167,7 @@ export default function AppFooter(props: AppFooterProps) {
</IconButton>
<IconButton
target="_blank"
rel="noopener noreferrer"
rel="noopener"
href={ROUTES.rssFeed}
aria-label="RSS Feed"
title="RSS Feed"
Expand All @@ -177,7 +177,7 @@ export default function AppFooter(props: AppFooterProps) {
</IconButton>
<IconButton
target="_blank"
rel="noopener noreferrer"
rel="noopener"
href="https://twitter.com/MUI_hq"
aria-label="twitter"
title="X"
Expand All @@ -187,7 +187,7 @@ export default function AppFooter(props: AppFooterProps) {
</IconButton>
<IconButton
target="_blank"
rel="noopener noreferrer"
rel="noopener"
href="https://www.linkedin.com/company/mui/"
aria-label="linkedin"
title="LinkedIn"
Expand All @@ -197,7 +197,7 @@ export default function AppFooter(props: AppFooterProps) {
</IconButton>
<IconButton
target="_blank"
rel="noopener noreferrer"
rel="noopener"
href="https://www.youtube.com/@MUI_hq"
aria-label="YouTube"
title="YouTube"
Expand All @@ -207,7 +207,7 @@ export default function AppFooter(props: AppFooterProps) {
</IconButton>
<IconButton
target="_blank"
rel="noopener noreferrer"
rel="noopener"
href="https://mui.com/r/discord/"
aria-label="Discord"
title="Discord"
Expand All @@ -218,7 +218,7 @@ export default function AppFooter(props: AppFooterProps) {
{stackOverflowUrl ? (
<IconButton
target="_blank"
rel="noopener noreferrer"
rel="noopener"
href={stackOverflowUrl}
aria-label="Stack Overflow"
title="Stack Overflow"
Expand Down
1 change: 0 additions & 1 deletion docs/src/modules/components/AdDisplay.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
/* eslint react/jsx-no-target-blank: ["error", { allowReferrer: true }] */
import * as React from 'react';
import PropTypes from 'prop-types';
import { styled } from '@mui/material/styles';
Expand Down
1 change: 0 additions & 1 deletion docs/src/modules/components/AdInHouse.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
/* eslint react/jsx-no-target-blank: ["error", { allowReferrer: true }] */
import * as React from 'react';
import PropTypes from 'prop-types';
import AdDisplay from 'docs/src/modules/components/AdDisplay';
Expand Down
2 changes: 1 addition & 1 deletion docs/src/modules/components/DemoErrorBoundary.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@ export default class DemoErrorBoundary extends React.Component {
</Typography>
<Typography>
{'We would appreciate it if you '}
<Link href={issueLink} rel="noreferrer" target="_blank">
<Link href={issueLink} rel="noopener" target="_blank">
report this error
</Link>
{` directly in our issue tracker with the steps you took to trigger it.
Expand Down
4 changes: 2 additions & 2 deletions docs/src/modules/components/DiamondSponsors.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@ export default function DiamondSponsors() {
data-ga-event-action="docs-premium"
data-ga-event-label="octopus.com"
href="https://octopus.com/?utm_source=materialui&utm_medium=referral"
rel="noopener noreferrer sponsored"
Copy link
Member Author

@oliviertassinari oliviertassinari Jan 6, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On a sponsor link, it cripples their analytics 🙈

rel="noopener sponsored"
target="_blank"
>
<Box
Expand All @@ -102,7 +102,7 @@ export default function DiamondSponsors() {
data-ga-event-action="docs-premium"
data-ga-event-label="doit.com"
href="https://www.doit.com/flexsave/?utm_source=materialui&utm_medium=referral"
rel="noopener noreferrer sponsored"
rel="noopener sponsored"
target="_blank"
>
<Box
Expand Down
2 changes: 1 addition & 1 deletion docs/src/modules/components/MaterialShowcase.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -519,7 +519,7 @@ export default function Showcase() {
}),
})}
>
<a href={app.link} rel="noopener nofollow noreferrer" target="_blank">
<a href={app.link} rel="noopener nofollow" target="_blank">
<CardMedia
component="img"
loading="lazy"
Expand Down
2 changes: 1 addition & 1 deletion docs/src/modules/components/TopLayoutBlog.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -383,7 +383,7 @@ export default function TopLayoutBlog(props) {
<Link
href={`https://github.com/${authors[author].github}`}
target="_blank"
rel="noreferrer noopener"
rel="noopener"
color="primary"
variant="body2"
sx={{ fontWeight: 500 }}
Expand Down
Loading