Skip to content

Conversation

@danilo-leal
Copy link
Collaborator

@danilo-leal danilo-leal commented Jan 10, 2024

This PR adds content about the Material UI Sync plugin to the Material UI and Design Kits pages.

@danilo-leal danilo-leal added the website Pages that are not documentation-related, marketing-focused. label Jan 10, 2024
@danilo-leal danilo-leal self-assigned this Jan 10, 2024
@mui-bot
Copy link

mui-bot commented Jan 10, 2024

Netlify deploy preview

https://deploy-preview-40515--material-ui.netlify.app/

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against fe138b0

@danilo-leal danilo-leal changed the title [website] Add content about MUI Connect [website] Add a Connect plug-in page Jan 18, 2024
@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged. label Jan 23, 2024
@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged. label Jan 24, 2024
@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged. label Jan 29, 2024
@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged. label Jan 29, 2024
@danilo-leal danilo-leal requested a review from zanivan April 29, 2024 21:19
@danilo-leal danilo-leal added the needs cherry-pick The PR should be cherry-picked to master after merge. label Apr 29, 2024
Copy link
Collaborator

@zanivan zanivan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good! Just pushed a small fix for layout shift, and have a couple of remarks:

Screenshot 2024-04-30 at 10 00 19
  • Here, I don't think we should have colorful icons, although I like them, it's not like this anywhere—so it's a bit odd to me.
  • The card layout is broken, cutting off the buttons

On a different note, I think it's worth changing the Design kits mentions to something broader, like “Design resources” or jut “Design”

Screenshot 2024-04-30 at 10 08 21 Screenshot 2024-04-30 at 10 08 29

@danilo-leal
Copy link
Collaborator Author

On a different note, I think it's worth changing the Design kits mentions to something broader, like “Design resources” or jut “Design”

@zanivan that makes sense, but there are some other related tasks (like fine-tuning the actual Design Kit description on the Store) that I'd find good to do before committing to this change. This design kit is very Material UI-centric, naturally, and we should go toward this clarity!

@danilo-leal danilo-leal requested a review from zanivan April 30, 2024 13:59
Copy link
Collaborator

@zanivan zanivan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found one more issue, the focus style doesn't seem to be working properly here:

Screenshot 2024-04-30 at 11 02 24 Screenshot 2024-04-30 at 11 02 38

@danilo-leal danilo-leal requested a review from zanivan April 30, 2024 14:22
Copy link
Collaborator

@zanivan zanivan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found a bug with the hover animation on the Design kit image:

Screen.Recording.2024-04-30.at.11.57.19.mov

@danilo-leal danilo-leal requested a review from zanivan April 30, 2024 16:08
Copy link
Collaborator

@zanivan zanivan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Design-wise looks good to me :)

@danilo-leal danilo-leal enabled auto-merge (squash) April 30, 2024 19:34
@danilo-leal danilo-leal merged commit 23bbf10 into mui:next Apr 30, 2024
github-actions bot pushed a commit that referenced this pull request Apr 30, 2024
@danilo-leal danilo-leal deleted the add-connect-content-website branch April 30, 2024 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs cherry-pick The PR should be cherry-picked to master after merge. website Pages that are not documentation-related, marketing-focused.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants