[code-infra] Move next config to ESM #40869
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Netlify deploy previewhttps://deploy-preview-40869--material-ui.netlify.app/ Bundle size report |
oliviertassinari
added
scope: code-infra
michaldudak
approved these changes
Feb 6, 2024
github-actions
bot
added
the
PR: out-of-date
Comment on lines
+7
to
+8
| import withDocsInfra from './nextConfigDocsInfra.js'; | ||
| import { findPages } from './src/modules/utils/find.mjs'; |
Member
There was a problem hiding this comment.
I'm curious about this. Why add the extensions?
Edit: oh lol really? https://nodejs.org/api/esm.html#mandatory-file-extensions
Mandatory file extensions
Member
Author
There was a problem hiding this comment.
node.js follows the native browser implementation in its resolver for esm, full paths mandatory. I guess it guarantees predictable amount of io access during module loading? It's more important on the web.
I think I saw somewhere that they're porting the classic node resolver to esm, but it's still experimental.
github-actions
bot
added
PR: out-of-date
github-actions
bot
removed
the
PR: out-of-date
github-actions
bot
added
the
PR: out-of-date
github-actions
bot
removed
the
PR: out-of-date
This was referenced May 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're having modules that are loaded both by the app and the config file (e.g.
docs/config). This change allows us to author them in ESM for both environments. I'm having trouble loading thedocs/configwhen moving it into@mui/docs