Skip to content

[base-ui][Switch] Add missing role attribute #40907

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
michaldudak merged 9 commits into from
Feb 14, 2024
Merged

[base-ui][Switch] Add missing role attribute #40907

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
85aedd9
[base-ui][Switch] Missing accessibility features
KirankumarAmbati Feb 3, 2024
354030f
[base-ui][Switch] fixed failing test
KirankumarAmbati Feb 3, 2024
5633626
[base-ui][Switch] fixed failing tests
KirankumarAmbati Feb 3, 2024
b9b6c02
[base-ui][Switch] undo test changes
KirankumarAmbati Feb 3, 2024
b6b08cf
[base-ui][Switch] changes to return role from hook
KirankumarAmbati Feb 8, 2024
cebb6b7
[base-ui][Switch] fixed tests
KirankumarAmbati Feb 8, 2024
085f8e4
Update packages/mui-joy/src/Checkbox/Checkbox.tsx
KirankumarAmbati Feb 9, 2024
a54f262
Update packages/mui-joy/src/Radio/Radio.tsx
KirankumarAmbati Feb 9, 2024
8f4894c
Trigger Build
KirankumarAmbati Feb 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
[base-ui][Switch] fixed failing test
  • Loading branch information
@KirankumarAmbati
KirankumarAmbati committed Feb 3, 2024
commit 354030ffab265b75b6905df431cccbb571c40a95
4 changes: 2 additions & 2 deletions packages/mui-base/src/useSwitch/useSwitch.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ describe('useSwitch', () => {
render(<Switch />);

act(() => {
screen.getByRole('checkbox').click();
screen.getByRole('switch').click();
});

expect(handleChange.callCount).to.equal(1);
Expand All @@ -85,7 +85,7 @@ describe('useSwitch', () => {
return <input {...getInputProps()} />;
}
render(<Switch />);
const checkbox = screen.getByRole('checkbox');
const checkbox = screen.getByRole('switch');

simulatePointerDevice();
act(() => {
Expand Down