[material-ui][docs] Remove Masonry component and Material Design icon from the landing page template #41080
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zanivan
added
docs
zanivan
changed the title
Netlify deploy previewhttps://deploy-preview-41080--material-ui.netlify.app/ Bundle size report |
| import ToggleButtonGroup from '@mui/material/ToggleButtonGroup'; | ||
| import AutoAwesomeRoundedIcon from '@mui/icons-material/AutoAwesomeRounded'; | ||
| import SvgMaterialDesign from 'docs/src/icons/SvgMaterialDesign'; | ||
| import AdbRoundedIcon from '@mui/icons-material/AdbRounded'; |
Contributor
There was a problem hiding this comment.
Is this the best icon choice to replace the MD logo? I would almost prefer the Google "G" instead, or even just an M for Material. Or else maybe we should just include the Material Design icon as an asset? I know it'll just get deleted by the developer, but it's pretty common to start a project by deleting assets from a boilerplate.
Collaborator
Author
There was a problem hiding this comment.
I replaced it for MD2. I think it's a good way to state the Material Design version, too.
github-actions
bot
added
the
PR: out-of-date
danilo-leal
approved these changes
Feb 15, 2024
Collaborator
danilo-leal
left a comment
danilo-leal
left a comment
There was a problem hiding this comment.
Two minor remarks but dropping approval already! 👍
docs/data/material/getting-started/templates/landing-page/LandingPage.js
Outdated
Show resolved
Hide resolved
docs/data/material/getting-started/templates/landing-page/components/Testimonials.tsx
Show resolved
Hide resolved
github-actions
bot
removed
the
PR: out-of-date
This was referenced Jul 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #41043
This PR removes the Masonry component and the Material Design Icon from the Landing page template.
👉 https://deploy-preview-41080--material-ui.netlify.app/material-ui/getting-started/templates/landing-page/