Skip to content

[docs-infra] Simplify copy logic #41167

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
oliviertassinari merged 3 commits into from
Feb 20, 2024
+16 −12
Merged

[docs-infra] Simplify copy logic #41167

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7f0bd35
[docs-infra] Simplify copy logic
oliviertassinari Feb 18, 2024
4bc1b4b
Flavien's review
oliviertassinari Feb 20, 2024
1cc1bfb
dead logic
oliviertassinari Feb 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Flavien's review
  • Loading branch information
@oliviertassinari
oliviertassinari committed Feb 20, 2024
commit 4bc1b4bc211ad1305decc9e589cda4f91bd7839b
8 changes: 4 additions & 4 deletions docs/src/modules/utils/CodeCopy.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -181,13 +181,13 @@ export function CodeCopyProvider({ children }: CodeCopyProviderProps) {
return;
}

const copyBtn = rootNode.current.querySelector('.MuiCode-copy') as HTMLButtonElement | null;
const copyBtn = rootNode.current.querySelector('.MuiCode-copy') as HTMLButtonElement;
const initialEventAction = copyBtn!.getAttribute('data-ga-event-action');
// update the 'data-ga-event-action' on the button to track keyboard interaction
copyBtn!.dataset.gaEventAction =
copyBtn.dataset.gaEventAction =
initialEventAction?.replace('click', 'keyboard') || 'copy-keyboard';
copyBtn!.click(); // let the GA setup in GoogleAnalytics.js do the job
copyBtn!.dataset.gaEventAction = initialEventAction!; // reset the 'data-ga-event-action' back to initial
copyBtn.click(); // let the GA setup in GoogleAnalytics.js do the job
copyBtn.dataset.gaEventAction = initialEventAction!; // reset the 'data-ga-event-action' back to initial
});
}, []);
return (
Expand Down