Skip to content

[docs-infra] Use edge function for card generation #41188

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alexfauquette merged 34 commits into from
Apr 10, 2024
Merged

[docs-infra] Use edge function for card generation #41188

Changes from 1 commit
Commits
Show all changes
34 commits
Select commit Hold shift + click to select a range
e11d71a
Make edge function work
alexfauquette Feb 19, 2024
7012f88
blog template
alexfauquette Feb 23, 2024
e2785b6
git api url
alexfauquette Feb 23, 2024
c437d42
test
alexfauquette Feb 27, 2024
4f341fd
fix
alexfauquette Feb 27, 2024
017c373
update
alexfauquette Feb 27, 2024
99d4b20
Merge remote-tracking branch 'upstream/master' into og-image
alexfauquette Feb 28, 2024
658d968
add small design tweaks
danilo-leal Mar 5, 2024
7901c63
tweak scope identifier text element
danilo-leal Mar 5, 2024
ae78278
Merge remote-tracking branch 'upstream/master' into og-image
alexfauquette Mar 6, 2024
b44ce6f
Merge branch 'og-image' of github.com:alexfauquette/material-ui into …
alexfauquette Mar 6, 2024
91b25a1
feedbacks
alexfauquette Mar 6, 2024
f5bdae3
fix
alexfauquette Mar 6, 2024
5f5e342
lint fix
alexfauquette Mar 6, 2024
14c47c0
fix missing product
alexfauquette Mar 11, 2024
fcbcfa0
add cache
alexfauquette Mar 11, 2024
04ea208
feedbacks
alexfauquette Mar 22, 2024
9d00180
small feedback
alexfauquette Mar 22, 2024
b4e1a65
Merge remote-tracking branch 'upstream/master' into og-image
alexfauquette Mar 22, 2024
fb84396
remove debug
alexfauquette Mar 22, 2024
8fcc08e
Fix typo
oliviertassinari Mar 26, 2024
1629679
move headers to manual card
alexfauquette Mar 29, 2024
ab4d35d
always use large card for blog post
alexfauquette Mar 29, 2024
d0203cc
Add description
alexfauquette Mar 29, 2024
bdc0b9a
Merge branch 'og-image' of github.com:alexfauquette/material-ui into …
alexfauquette Mar 29, 2024
4b2f937
add IBM font
alexfauquette Mar 29, 2024
269a340
Merge remote-tracking branch 'upstream/master' into og-image
alexfauquette Mar 29, 2024
b20e681
Update netlify/edge-functions/og-image.tsx
alexfauquette Apr 2, 2024
50f3802
modify font-size
alexfauquette Apr 3, 2024
44b92b8
refine the card generation docs
alexfauquette Apr 3, 2024
c6c0c6e
fix typos
alexfauquette Apr 3, 2024
32caa7f
add in the nav bar
alexfauquette Apr 3, 2024
0e9d920
tweak documentation
danilo-leal Apr 3, 2024
a570b9a
fine-tune the OG card design
danilo-leal Apr 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
always use large card for blog post
  • Loading branch information
@alexfauquette
alexfauquette committed Mar 29, 2024
commit ab4d35dd07f1dad74a69d88ad5da3e90a68fdfa8
10 changes: 5 additions & 5 deletions docs/src/modules/components/TopLayoutBlog.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -270,7 +270,7 @@ export default function TopLayoutBlog(props) {
const slug = router.pathname.replace(/(.*)\/(.*)/, '$2');
const { canonicalAsServer } = pathnameToLanguage(router.asPath);
const card =
headers.card === 'true'
headers.manualCard === 'true'
? `https://mui.com/static/blog/${slug}/card.png`
: `/edge-functions/og-image/?title=${headers.cardTitle || finalTitle}&authors=${headers.authors
.map((author) => {
Expand All @@ -280,11 +280,11 @@ export default function TopLayoutBlog(props) {
.join(',')}&product=Blog`;

if (process.env.NODE_ENV !== 'production') {
if (headers.card === undefined) {
if (headers.manualCard === undefined) {
throw new Error(
[
`MUI: the "card" markdown header for the blog post "${slug}" is missing.`,
`Set card: true or card: false header in docs/pages/blog/${slug}.md.`,
`MUI: the "manualCard" markdown header for the blog post "${slug}" is missing.`,
`Set manualCard: true or manualCard: false header in docs/pages/blog/${slug}.md.`,
].join('\n'),
);
}
Expand All @@ -296,7 +296,7 @@ export default function TopLayoutBlog(props) {
<Head
title={`${finalTitle} - MUI`}
description={description}
largeCard={headers.card === 'true'}
largeCard
disableAlternateLocale
card={card}
type="article"
Expand Down