[docs-infra] Add spacing and contrast improvements #41191
Conversation
danilo-leal
added
accessibility
Netlify deploy previewhttps://deploy-preview-41191--material-ui.netlify.app/ Bundle size report |
| borderColor: 'divider', | ||
| }} | ||
| > | ||
| <Button |
There was a problem hiding this comment.
Feels a bit weird to have nothing do show a distinction between the nav and sponsors. And the explaination about what are those logo can only be inferred from the "Become a Diamond sponsor" after them.
There was a problem hiding this comment.
I felt like having both the "Become a Diamond Sponsor" and "Diamond Sponsor" buttons was redundant, particularly as they were taking to, essentially, the same place. I experimented with adding a "Sponsors" nav label, sort of similar to the "Contents" on the top of the TOC, but felt like visitors would be able to understand what these logos are even without a label?
github-actions
bot
added
the
PR: out-of-date
github-actions
bot
removed
the
PR: out-of-date
zanivan
left a comment
zanivan
left a comment
There was a problem hiding this comment.
Looks good! Just a small comment:
I know it is probably because of the border left, but it feels kinda off to have no border radius on this, since everything else has.
|
@zanivan yeah, good call! Definitely a detail I want to treat (and the way I'd probably do something similar to the side nav, with pseudo-elements), but I'll keep this one simple! If I were to throw in a border-radius in there, it'd look janky like this: 
|
I thought that might be the case 😅 |
4 participants
The commits are as isolated as possible for ease of review. This PR is mostly tiny fixes for adding focus-visible styles and spacing adjustments throughout a couple of docs-infra-related components.
To test it, try tabbing through the table of contents items or the page's body to see improved focus-visible styles, for example.
https://deploy-preview-41191--material-ui.netlify.app/material-ui/getting-started/