[material-ui][docs] Adjust the Templates card design #41450
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danilo-leal
added
docs
Netlify deploy previewBundle size report |
DiegoAndai
reviewed
Mar 11, 2024
Member
DiegoAndai
left a comment
DiegoAndai
left a comment
There was a problem hiding this comment.
The "Live preview" change makes total sense to me 👍🏼
I'm not so sure about the added padding:
Feels to me that we loose real state compared to the previous implementation
Collaborator
Author
|
True, yeah; both work, but the current design's slightly bigger image is indeed beneficial. Good call 👌 |
zanivan
reviewed
Mar 11, 2024
Collaborator
zanivan
left a comment
zanivan
left a comment
There was a problem hiding this comment.
Thanks so much for tackling this! It was on my list to review this page after I've finished all the templates.
I Agree with @DiegoAndai though, we could leave more space for the template thumbnail. What if we had two cards like Joy UI?
1 task
This was referenced May 19, 2024
This was referenced May 20, 2024
This was referenced May 21, 2024
This was referenced Jun 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wasn't enjoying how the "Live Preview" button was hidden beneath a hover on the template's thumbnail; I think most people would want to quickly check out what the template looks like before diving deeper into the source code. So, this PR, ultimately, approximates the card design to the one we're already using on the Joy UI docs, making both buttons side to side.
https://deploy-preview-41450--material-ui.netlify.app/material-ui/getting-started/templates/