Skip to content
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
[joy-ui][docs] Optimize side navigation's relative contrast
The right sidebar has been updated to the ‘solid’ variant for improved interaction with IconButtons.
It is now darker than the left sidebar, creating better relative contrast and lifting the left
sidebar higher on the screen. Additionally, the styles are consistent whether in light or dark mode,
addressing previous issue where the right sidebar appeared higher/lower based on the color
scheme.
  • Loading branch information
cipherlogs committed Mar 12, 2024
commit e41b24f59a9be91accd2f67e67f49553cdeb97f8
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ export default function ColorInversionNavigation() {
sx={{
p: 2,
...(color !== 'neutral' && {
bgcolor: `${color}.800`,
bgcolor: `${color}.700`,
}),
}}
>
Expand Down Expand Up @@ -131,17 +131,15 @@ export default function ColorInversionNavigation() {
</Card>
</Sheet>
<Sheet
variant="soft"
variant="solid"
color="neutral"
invertedColors
sx={(theme) => ({
p: 2,
display: 'flex',
flexDirection: 'column',
gap: 2,
...(color !== 'neutral' && {
bgcolor: `${color}.900`,
}),
bgcolor: `${color}.900`,
'& button': {
borderRadius: '50%',
padding: 0,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ export default function ColorInversionNavigation() {
sx={{
p: 2,
...(color !== 'neutral' && {
bgcolor: `${color}.800`,
bgcolor: `${color}.700`,
}),
}}
>
Expand Down Expand Up @@ -139,9 +139,7 @@ export default function ColorInversionNavigation() {
display: 'flex',
flexDirection: 'column',
gap: 2,
...(color !== 'neutral' && {
bgcolor: `${color}.900`,
}),
bgcolor: `${color}.900`,
'& button': {
borderRadius: '50%',
padding: 0,
Expand Down