Skip to content

[docs-infra] Fix analytics about inline ads #41474

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alexfauquette merged 3 commits into from
Apr 5, 2024
Merged

[docs-infra] Fix analytics about inline ads #41474

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3d0da0c
[docs] Get analytics about inline ads
alexfauquette Mar 13, 2024
b8bb039
send inline ad display event
alexfauquette Mar 13, 2024
ddff14b
Synchronise ratio between demo and header ads
alexfauquette Mar 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions docs/src/modules/components/AdCarbon.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,6 +126,7 @@ export function AdCarbonInline(props) {
name: ad.company,
description: `<strong>${ad.company}</strong> - ${ad.description}`,
poweredby: 'Carbon',
label: 'carbon-demo-inline',
}}
/>
</React.Fragment>
Expand Down
12 changes: 12 additions & 0 deletions docs/src/modules/components/AdDisplay.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,18 @@ const Root = styled('span', { shouldForwardProp: (prop) => prop !== 'shape' })((
export default function AdDisplay(props) {
const { ad, className, shape = 'auto' } = props;

React.useEffect(() => {
// Avoid an exceed on the Google Analytics quotas.
if (Math.random() < 0.9 || !ad.label) {
return;
}
Copy link
Member

@siriwatknp siriwatknp Mar 14, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you explain more what's this for?

Copy link
Member Author

@alexfauquette alexfauquette Mar 14, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure about which aspect is unclear.

The early return is just a way to send only 10% of the ads display event to Goggle Analitics. A similar approach is used for top page ads

Copy link
Member Author

@alexfauquette alexfauquette Mar 14, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added a commit to make sure this ratio is consistent between all ads


window.gtag('event', 'ad', {
eventAction: 'display',
eventLabel: ad.label,
});
}, [ad.label]);

/* eslint-disable material-ui/no-hardcoded-labels, react/no-danger */
return (
<Root shape={shape === 'inline' ? 'inline' : adShape} className={className}>
Expand Down