Skip to content

[website] Improve navbar's items hover state #41535

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
danilo-leal merged 9 commits into from
Mar 18, 2024
Merged

[website] Improve navbar's items hover state #41535

Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
c4712ae
Update star count to 90.5k
EyaOuenniche Jan 23, 2024
fb63c9b
Improved the type naming in the fade api
EyaOuenniche Feb 23, 2024
d65adb3
Add hover effect to navbar links by changing link color
EyaOuenniche Mar 17, 2024
e2e9df7
Merge branch 'master' into feature/navbar-hover-color
EyaOuenniche Mar 17, 2024
b8d70d0
Merge branch 'master' into pr/41535
danilo-leal Mar 18, 2024
0a515b0
remove unrelated changes from this PR
danilo-leal Mar 18, 2024
7673cbd
tweak styles to be more subtle (no need for the blue color)
danilo-leal Mar 18, 2024
23507ba
remove not needed line-break
danilo-leal Mar 18, 2024
6b81685
Merge branch 'master' into pr/41535
danilo-leal Mar 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions docs/src/components/header/HeaderNavBar.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,8 +27,8 @@ const Navigation = styled('nav')(({ theme }) => [
},
'& li': {
...theme.typography.body2,
color: (theme.vars || theme).palette.text.primary,
fontWeight: theme.typography.fontWeightBold,
color: (theme.vars || theme).palette.text.secondary,
fontWeight: theme.typography.fontWeightSemiBold,
'& > a, & > button': {
display: 'inline-block',
color: 'inherit',
Expand All @@ -38,7 +38,7 @@ const Navigation = styled('nav')(({ theme }) => [
borderRadius: (theme.vars || theme).shape.borderRadius,
border: '1px solid transparent',
'&:hover': {
color: (theme.vars || theme).palette.grey[900],
color: (theme.vars || theme).palette.text.primary,
backgroundColor: (theme.vars || theme).palette.grey[50],
borderColor: (theme.vars || theme).palette.grey[100],
'@media (hover: none)': {
Expand Down