Skip to content

Conversation

@DiegoAndai
Copy link
Member

@DiegoAndai DiegoAndai commented Mar 21, 2024

Convert Chip component to support CSS extraction.

Screen.Recording.2024-03-21.at.12.01.13.mov

@DiegoAndai DiegoAndai added scope: chip Changes related to the chip. package: material-ui labels Mar 21, 2024
@DiegoAndai DiegoAndai self-assigned this Mar 21, 2024
@mui-bot
Copy link

mui-bot commented Mar 21, 2024

Netlify deploy preview

https://deploy-preview-41592--material-ui.netlify.app/

Bundle size report

Details of bundle changes (Toolpad)
Details of bundle changes

Generated by 🚫 dangerJS against e7cf86c

@DiegoAndai DiegoAndai requested review from brijeshb42 and siriwatknp and removed request for brijeshb42 March 21, 2024 15:19
@DiegoAndai DiegoAndai marked this pull request as ready for review March 21, 2024 15:19
@DiegoAndai
Copy link
Member Author

Updated recording:

Screen.Recording.2024-03-22.at.17.52.02.mov

@DiegoAndai DiegoAndai requested a review from siriwatknp March 22, 2024 20:52
@DiegoAndai DiegoAndai requested a review from siriwatknp March 25, 2024 18:49
Copy link
Member

@siriwatknp siriwatknp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks great!

@DiegoAndai DiegoAndai merged commit 4e9d011 into mui:next Mar 26, 2024
@DiegoAndai DiegoAndai deleted the chip-css-extraction branch March 26, 2024 12:27
tejasparkar pushed a commit to tejasparkar/material-ui that referenced this pull request Mar 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

scope: chip Changes related to the chip.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants