Skip to content

Conversation

@siriwatknp
Copy link
Member

@siriwatknp siriwatknp commented Mar 27, 2024

Issue: https://mui.com/material-ui/, see #41201 (comment)

image

I don't have time to dig down to the root cause at the moment. This is a quick fix to get rid of the styles generation error.

After: https://deploy-preview-41676--material-ui.netlify.app/material-ui/

image

@siriwatknp siriwatknp requested a review from mnajdova March 27, 2024 10:29
@siriwatknp siriwatknp added scope: slider Changes related to the slider. package: material-ui labels Mar 27, 2024
@mui-bot
Copy link

mui-bot commented Mar 27, 2024

Netlify deploy preview

https://deploy-preview-41676--material-ui.netlify.app/

Bundle size report

Details of bundle changes (Toolpad)
Details of bundle changes

Generated by 🚫 dangerJS against 40af0c9

@oliviertassinari
Copy link
Member

@siriwatknp could we check what's the root cause here? It feels like its important that we have full clarity on how our code behaves. I would say this in general, I think we should pursue all our confusions, at least it's incredibly hard for me to let go. But here, since we go after backward compatibility, it feels core to what we do. At minimum, I belive we need a GitHub issue to figure this out before releasing v6.

@siriwatknp
Copy link
Member Author

@siriwatknp could we check what's the root cause here? It feels like its important that we have full clarity on how our code behaves. I would say this in general, I think we should pursue all our confusions, at least it's incredibly hard for me to let go. But here, since we go after backward compatibility, it feels core to what we do. At minimum, I belive we need a GitHub issue to figure this out before releasing v6.

I agree. It's hard for me to let go too but I don't have resource to get into this right now.

I will create an issue for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

scope: slider Changes related to the slider.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants