[website] Fix home page slider's track position #42141
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aarongarciah
added
the
website
aarongarciah
commented
May 6, 2024
| fontWeight: 'semiBold', | ||
| }, | ||
| [`& .${sliderClasses.thumb}`]: { | ||
| mx: -1, |
Member
Author
There was a problem hiding this comment.
@danilo-leal everything seems to work just fine, but let me know if there was another reason to include this.
Netlify deploy previewhttps://deploy-preview-42141--material-ui.netlify.app/ Bundle size report |
aarongarciah
added
the
needs cherry-pick
aarongarciah
force-pushed
the
aarongarciah/fix-home-page-slider
branch
from
3809fe7 to
80a9980
Compare
danilo-leal
approved these changes
May 6, 2024
Collaborator
danilo-leal
left a comment
danilo-leal
left a comment
There was a problem hiding this comment.
Looks good! That margin there was to offset a bug within the Slider itself, which got fixed, thus making it unnecessary :) Good catch.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It looks like #41547 introduced a small visual glitch on the home page slider because the slider track ends are not centered within the slider thumbs.