Skip to content

[core] Replace enzyme in describeConformance #42447

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aarongarciah merged 8 commits into from
Jun 18, 2024
Merged

[core] Replace enzyme in describeConformance #42447

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
01660be
Remove enzyme from testPropsSpread test
DiegoAndai May 29, 2024
c984272
Remove enzyme from describeRef test
DiegoAndai May 29, 2024
96d29af
Remove enzyme from testClassName test
DiegoAndai May 29, 2024
a891f02
Remove enzyme from testComponentProp test
DiegoAndai May 29, 2024
ae0b1da
Remove enzyme from testComponentsProp test
DiegoAndai May 29, 2024
d0b2593
Remove mount from describeConformance
DiegoAndai May 29, 2024
aceac7d
Automatically set data-testid
aarongarciah Jun 14, 2024
3a6ae48
Do not spread key prop
aarongarciah Jun 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Do not spread key prop
  • Loading branch information
@aarongarciah
aarongarciah committed Jun 18, 2024
commit 3a6ae48cc8e975e2a474b6f9a48540a3ce4d506f
11 changes: 8 additions & 3 deletions packages/mui-joy/src/Autocomplete/Autocomplete.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -632,9 +632,14 @@ const Autocomplete = React.forwardRef(function Autocomplete(
},
});

const defaultRenderOption = (optionProps: any, option: unknown) => (
<SlotOption {...optionProps}>{getOptionLabel(option)}</SlotOption>
);
const defaultRenderOption = (optionProps: any, option: unknown) => {
const { key, ...rest } = optionProps;
return (
<SlotOption key={key} {...rest}>
{getOptionLabel(option)}
</SlotOption>
);
};

const renderOption = renderOptionProp || defaultRenderOption;

Expand Down