Skip to content

[core] Bump React to 19 #42824

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
aarongarciah wants to merge 42 commits into from
Closed

[core] Bump React to 19 #42824

Changes from 1 commit
Commits
Show all changes
42 commits
Select commit Hold shift + click to select a range
369c230
Bump React to 19
aarongarciah Jul 2, 2024
0fce693
Run useRef codemod
DiegoAndai Jul 3, 2024
91803b0
Remove resolutions for @types/react
Janpot Jul 19, 2024
73c1cc4
patch deps
Janpot Jul 19, 2024
1de7c1a
docs
Janpot Jul 19, 2024
9e858c5
Update some React refs types and default values
aarongarciah Jul 22, 2024
2a3e5c0
Stop using deprecated React.MutableRefObject
aarongarciah Jul 22, 2024
1d5a94f
Fix next types
Janpot Jul 25, 2024
7f15351
Fix remaining element.ref access issues
DiegoAndai Jul 31, 2024
63aad34
Remove stale util
DiegoAndai Aug 1, 2024
7a03c0d
Fix Modal test
aarongarciah Aug 9, 2024
2d1241d
Undo some React.MutableRefObject changes
aarongarciah Aug 13, 2024
f42adaa
Revert "Fix Modal test"
aarongarciah Aug 15, 2024
ced416f
Adapt Modal test to pass
aarongarciah Aug 15, 2024
d1ee2ee
Update @floating-ui transitive dependencies
aarongarciah Aug 20, 2024
b6169a4
Update Next.js
aarongarciah Aug 27, 2024
1100354
Disable Next.js workerThreads
aarongarciah Aug 27, 2024
032cfc3
Adapt envinfo test to pass
aarongarciah Aug 26, 2024
c603f89
pnpm dedupe
aarongarciah Oct 7, 2024
5659b2a
Patch styled-components types
aarongarciah Oct 8, 2024
9c37cac
Merge branch 'master' into react-19
DiegoAndai Nov 12, 2024
06e3c34
Pin next to 15.0.2 temporarily
DiegoAndai Nov 12, 2024
e2637d4
Trigger CI
DiegoAndai Nov 12, 2024
0e34c2c
Merge branch 'master' into react-19
DiegoAndai Nov 13, 2024
6434117
Merge branch 'master' into react-19
DiegoAndai Nov 13, 2024
5e06d10
Update material-nextjs next version to canary
DiegoAndai Nov 13, 2024
2f3487d
Update to latest React rc
DiegoAndai Nov 13, 2024
99ef5eb
Use skipLibCheck instead of sc patch
DiegoAndai Nov 13, 2024
b40b413
Trigger CI
DiegoAndai Nov 13, 2024
8239a6e
Update React to 19.0.0-rc.1
DiegoAndai Nov 15, 2024
efb3518
Try medium+ container to see if killed signal is due to OOM
DiegoAndai Nov 15, 2024
d29bc49
Merge branch 'master' into react-19
DiegoAndai Dec 6, 2024
88c81a4
Update packages to stable versions
DiegoAndai Dec 6, 2024
8a0289b
Skip lib check in system due to sc
DiegoAndai Dec 6, 2024
f3eaaae
Adapt useCurrentColorScheme test to React 19
DiegoAndai Dec 6, 2024
5479511
Use medium+ containers for this PR
DiegoAndai Dec 6, 2024
0ebf220
Revert envinfo test change
DiegoAndai Dec 6, 2024
9348865
Refactor useCurrentColorScheme test
DiegoAndai Dec 6, 2024
b5459e7
Remove unnecessary version specifying
DiegoAndai Dec 6, 2024
bc6f888
Support React 18 in useCurrentColorScheme test
DiegoAndai Dec 6, 2024
531bd6a
Bump next to 15.0.4
DiegoAndai Dec 6, 2024
9bfbece
Revert incorrect merge resolution in mui-base package.json
DiegoAndai Dec 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Support React 18 in useCurrentColorScheme test
  • Loading branch information
@DiegoAndai
DiegoAndai committed Dec 6, 2024
commit bc6f8885e3ad21f81df581f3895c97bcd2af08e7
4 changes: 2 additions & 2 deletions packages/mui-system/src/cssVars/useCurrentColorScheme.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import * as React from 'react';
import { expect } from 'chai';
import { spy } from 'sinon';
import { createRenderer, fireEvent, act, screen } from '@mui/internal-test-utils';
import { createRenderer, fireEvent, act, screen, reactMajor } from '@mui/internal-test-utils';
import {
DEFAULT_MODE_STORAGE_KEY,
DEFAULT_COLOR_SCHEME_STORAGE_KEY,
Expand Down Expand Up @@ -101,7 +101,7 @@ describe('useCurrentColorScheme', () => {
const { container } = render(<Data />);

expect(container.firstChild.textContent).to.equal('light');
expect(effectRunCount).to.equal(2);
expect(effectRunCount).to.equal(reactMajor >= 19 ? 2 : 3);
Copy link
Member

@DiegoAndai DiegoAndai Dec 6, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This test was recently added, that's why we didn't cover it before in this PR.

The previous approach didn't work with React 19, probably due to the changes to strict mode. The difference in events between 18 and 19 is the following:

 render
 render
 run effect
-run effect (this one doesn't run in React 19)
 render
 render
 run effect

And for both, the last effect run wasn't being registered in the rendered content. That's why with React 18 the result was light:2 even though the effect runs 3 times. For React 19, the effect is runs 2 times.

Copy link
Member

@DiegoAndai DiegoAndai Dec 6, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc: @siriwatknp

});

it('[noSsr] does not trigger a re-render', () => {
Expand Down
Loading