[docs] Add dashboard with CRUD template based on Toolpad Core #46376
Conversation
Netlify deploy previewBundle size report
|
apedroferreira
changed the title
github-actions
bot
added
the
PR: out-of-date
apedroferreira
changed the title
github-actions
bot
removed
the
PR: out-of-date
apedroferreira
changed the title
Thanks, I've addressed all of those now. |
|
Sorry for the delay. The file structure looks good. I see some inconsistencies with the other templates, for example: ButtonsButtons sizes are 40x40 on this one and 36x36 on the other ones. Also the icons inside them look too big. CRUD dashboard Dashboard BreadcrumbsCRUD dashboard Dashboard Nav barCRUD dashboard Dashboard I think we could copy a lot of these from the other templates so we can keep them consistent and of a higher quality. Let me know if this is out of scope. |
Hi Diego, thanks for taking the time to review this! Just for context — this is an attempt to retroactively purpose what we had in the Toolpad library as a template. As the Toolpad library's design did not exactly match the one in these templates, there are definitely some inconsistencies if we list all these templates together in the same page. I already adjusted the theming here to try to fix some visual issues and match the look-and-feel of the others, but I'm not sure if that wasn't already out of scope... I'm also not sure if this template is not slightly redundant or truly belongs in this section, as probably the previous templates were designed, built and grouped together more intentionally (I don't have the whole context about them). I can try to address just the most doable design inconsistencies if we have a short list of them, or it could be considered to include this particular template in another section or page. Not sure what the best decision is or that I have the knowledge needed to make the best decision in this case. I'm happy to let you guys figure that out later too. |
|
This does belong in the templates page, so no need to move it to another page. Lets move it to the bottom of the list, right before the premium templates. Here's the list of design consistency issues I would like to fix before merging:
You should be able to copy and paste styles/components from https://mui.com/material-ui/getting-started/templates/dashboard/ to make this easier. It's ok to duplicate these 👍🏼 Finally, let's add a border to this so it doesn't blend into the background: With those four things fixes this looks good to me 👍🏼 Let me know if you need any help! |
Sounds good, thanks for the help and the clarity! I'll try to address all the items you mentioned. |
I've addressed all your points, please take a look when you have the time and let me know if it's good now! |
docs/data/material/getting-started/templates/crud-dashboard/components/EmployeeEdit.js
Outdated
Show resolved
Hide resolved
…mponents/EmployeeEdit.js Co-authored-by: Jan Potoms <[email protected]> Signed-off-by: Pedro Ferreira <[email protected]>
DiegoAndai
left a comment
DiegoAndai
left a comment
There was a problem hiding this comment.
Thanks for addressing the feedback @apedroferreira! Good to merge from my side
| id: 1, | ||
| name: 'Edward Perry', | ||
| age: 25, | ||
| joinDate: new Date().toISOString(), |
|
I'm late to this. Great idea to have a CRUD template as a temporary solution for Toolpad users 👍 |
5 participants
You can find and try the new template at https://deploy-preview-46376--material-ui.netlify.app/material-ui/getting-started/templates/ (CRUD dashboard)
https://deploy-preview-46376--material-ui.netlify.app/material-ui/getting-started/templates/crud-dashboard/
This template can be used for Toolpad Core users to possibly "eject" their projects and customize them more freely.