Skip to content

[fields] Handle focusing container with inputRef.current.focus on accessibleFieldDOMStructure #15985

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
LukasTy merged 5 commits into from
Dec 30, 2024
Merged

[fields] Handle focusing container with inputRef.current.focus on accessibleFieldDOMStructure #15985

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
40a0ba4
[fields] Handle focusing container with `inputRef.current.focus` on `…
LukasTy Dec 23, 2024
d240a91
Merge branch 'master' into field-ref-usage
LukasTy Dec 30, 2024
af561bc
Merge branch 'master' into field-ref-usage
LukasTy Dec 30, 2024
7943aa6
Add a test to assert the added behavior
LukasTy Dec 30, 2024
330ff1a
fix eslint
LukasTy Dec 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions packages/x-date-pickers/src/PickersTextField/PickersInputBase/PickersInputBase.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -247,6 +247,10 @@ const PickersInputBase = React.forwardRef(function PickersInputBase(
onFocus?.(event);
};

const handleHiddenInputFocus = (event: React.FocusEvent<HTMLInputElement>) => {
handleInputFocus(event);
};

const handleInputBlur = (event: React.FocusEvent<HTMLDivElement>) => {
muiFormControl.onBlur?.(event);
onBlur?.(event);
Expand Down Expand Up @@ -338,6 +342,9 @@ const PickersInputBase = React.forwardRef(function PickersInputBase(
readOnly={readOnly}
required={muiFormControl.required}
disabled={muiFormControl.disabled}
// Hidden input element cannot be focused, trigger the root focus instead
// This allows to maintain the ability to do `inputRef.current.focus()` to focus the field
onFocus={handleHiddenInputFocus}
{...inputProps}
ref={handleInputRef}
/>
Expand Down
Loading