Skip to content

[notifications] Fix: #4959 transition on close #4960

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dchae wants to merge 6 commits into
base: master
Choose a base branch
from
Open

[notifications] Fix: #4959 transition on close #4960

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
bd3718e
Fix: Notification transitions are now properly applied on close
dchae May 18, 2025
8d8798c
Chore: Update useNotifications.test.tsx to wait for close timeout
dchae May 18, 2025
27b6f93
Chore: refactor NotificationsProvider to use React.Transition.onExite…
dchae May 23, 2025
d283fa1
Fix: Passing in props to NotificationsProvider no longer breaks Notif…
dchae May 23, 2025
d672d55
Merge branch 'master' into useNotifications-transition-fix
dchae May 23, 2025
685eebb
Fix: Fixed types (added RemoveNotification type to context type)
dchae May 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Merge branch 'master' into useNotifications-transition-fix
  • Loading branch information
@dchae
dchae authored May 23, 2025
commit d672d551eedae88efeef109d31819a2f823d7d33

This merge commit was added into this branch cleanly.

There are no new changes to show, but you can still view the diff.