Skip to content

Pass count as keyword argument to re.sub() #197

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 26, 2023
Merged

Pass count as keyword argument to re.sub() #197

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2864540
Pass `count` as keyword argument to `re.sub()`
rathann Nov 21, 2023
83fa66d
Merge remote-tracking branch 'rathann/python-3.13' into stanislaw/pyt…
stanislaw Nov 26, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Pass count as keyword argument to re.sub() 
This fixes two test failures under Python 3.13:

```
Failed Tests (2):
  FileCheck.py integration tests :: tests/extra_features/pseudo_numeric_variables/01_line_variable_once/test.itest
  FileCheck.py integration tests :: tests/extra_features/pseudo_numeric_variables/02_line_variable_twice/test.itest
```

Both are failing due to:

```
filecheck/filecheck.py:372: DeprecationWarning: 'count' is passed as positional argument
```

Passing `count` as positional argument to `re.sub()` has been deprecated
in Python 3.13: https://docs.python.org/3.13/whatsnew/3.13.html#id9
and produces a `DeprecationWarning` exception.
  • Loading branch information
@rathann
rathann committed Nov 21, 2023
commit 2864540445fb1bbf7791e5eea9315b952b6264fd
2 changes: 1 addition & 1 deletion filecheck/filecheck.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -374,7 +374,7 @@ def parse_check(line: str, line_idx, config: Config) -> Optional[Check]:
LINE_NUMBER_REGEX,
str(line_idx + offset + 1),
check_expression,
1,
count=1,
)
line_var_match = re.search(LINE_NUMBER_REGEX, check_expression)

Expand Down