Switch to Rust 2024 edition #8237
Merged
+861
−788
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Serock3
force-pushed
the
switch-to-rust-2024-des-2199
branch
5 times, most recently
from
6fc4ef5 to
1a57945
Compare
Serock3
force-pushed
the
switch-to-rust-2024-des-2199
branch
from
1a57945 to
bdd16c4
Compare
Serock3
force-pushed
the
switch-to-rust-2024-des-2199
branch
3 times, most recently
from
aa0bb29 to
5211667
Compare
Serock3
force-pushed
the
switch-to-rust-2024-des-2199
branch
11 times, most recently
from
0b80cd0 to
f7e9070
Compare
Serock3
force-pushed
the
switch-to-rust-2024-des-2199
branch
from
f7e9070 to
60f2e8b
Compare
Serock3
force-pushed
the
switch-to-rust-2024-des-2199
branch
from
60f2e8b to
fa1154c
Compare
Serock3
force-pushed
the
switch-to-rust-2024-des-2199
branch
from
fa1154c to
c051b4c
Compare
Serock3
force-pushed
the
switch-to-rust-2024-des-2199
branch
4 times, most recently
from
9111374 to
7d7c8e7
Compare
Serock3
force-pushed
the
switch-to-rust-2024-des-2199
branch
from
7d7c8e7 to
527c8da
Compare
MarkusPettersson98
approved these changes
Jul 10, 2025
Contributor
MarkusPettersson98
left a comment
MarkusPettersson98
left a comment
There was a problem hiding this comment.
Reviewed 3 of 27 files at r1, 23 of 272 files at r2, 3 of 12 files at r3, all commit messages.
Reviewable status: 27 of 288 files reviewed, all discussions resolved
|
🚨 End to end tests failed. Please check the failed workflow run. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR switches the Rust version to 2024, updates the Rust version to 1.87.0, and fixes new lints resulting from this.
Note that the new lint against large error-enums triggers on
tonic::Status, which I solved by boxing it. A PR intonicto fix this internally has been merged, and should be released with the upcoming 0.14 version hyperium/tonic#2282.Also note that the default (stable) formatting rules seem to have changed. All the files that I touched also had other formatting changes done to them by rust-analyzer, which I left in, but I did not bother running
cargo fmtas it changes every file in the workspace which would make the PR state immediately.This change is