Skip to content

refactor: Follows up on #261 #264

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Feb 6, 2025
Merged

refactor: Follows up on #261 #264

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
fb9e37d
add comment
MarcoPolo Feb 6, 2025
46fc513
decorate err
MarcoPolo Feb 6, 2025
c1bd101
rename offset field
MarcoPolo Feb 6, 2025
d55c284
more validation checks
MarcoPolo Feb 6, 2025
ea5f441
Add benchmark for component validation
MarcoPolo Feb 6, 2025
47c55fc
Use *Protocol in Component
MarcoPolo Feb 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add benchmark for component validation
  • Loading branch information
@MarcoPolo
MarcoPolo committed Feb 6, 2025
commit ea5f441c63c2615f416e25ca8d9fb117e300117f
14 changes: 14 additions & 0 deletions multiaddr_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1132,3 +1132,17 @@ func FuzzSplitRoundtrip(f *testing.F) {
}
})
}

func BenchmarkComponentValidation(b *testing.B) {
comp, err := NewComponent("ip4", "127.0.0.1")
if err != nil {
b.Fatal(err)
}
b.ReportAllocs()
for i := 0; i < b.N; i++ {
_, err := validateComponent(comp)
if err != nil {
b.Fatal(err)
}
}
}