-
Notifications
You must be signed in to change notification settings - Fork 3k
Add Windows application manifest #30886
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
cbjeukendrup
merged 2 commits into
musescore:master
from
juli27:addWindowsApplicationManifest
Dec 10, 2025
Merged
Add Windows application manifest #30886
cbjeukendrup
merged 2 commits into
musescore:master
from
juli27:addWindowsApplicationManifest
Dec 10, 2025
+52
−54
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
7c4d375 to
ade3034
Compare
cbjeukendrup
approved these changes
Nov 5, 2025
Member
|
@DmitryArefiev This one only needs testing on Windows. Just a small regression check; maybe the following things:
|
igorkorsukov
reviewed
Nov 6, 2025
ade3034 to
d1d4b6e
Compare
igorkorsukov
approved these changes
Nov 6, 2025
d1d4b6e to
d21ac03
Compare
The manifest contains four things:
- declare compatibility with Windows 10 & 11
- we were running inside a Windows Vista compatibility context before
- set process DPI awareness to PerMonitorV2
- this is already set by Qt programmatically at start up
- use v6 instead of v5 of the CommonControls library
- enable modern styles in system dialogs
- user account control settings
- for completeness. The linker adds that by default anyway, so this
was already part of the executable
This effectively reverts fb63d3e
d21ac03 to
aa5f9cc
Compare
Contributor
@cbjeukendrup Tested on Win10. PASS. Please review if needed (or just merge) |
cbjeukendrup
approved these changes
Dec 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The manifest contains five things:
The compatibility declaration with Windows 10 & 11 might change behavior or might not. (I don't expect any changes in behavior)
Another thing we could do is set the process's codepage to UTF-81. This might allow as to drop this call toQTextCodec::setCodecForLocalefrom Qt6Core5Compat.Print dialog with Windows 10:
Footnotes
https://learn.microsoft.com/en-us/windows/win32/sbscs/application-manifests#activecodepage ↩