Skip to content

Text mark #3051

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mwaskom merged 12 commits into from
Oct 4, 2022
Merged

Text mark #3051

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
7da1bd0
POC for Text mark
mwaskom Sep 30, 2022
b44c8c4
Add unit tests for Text mark
mwaskom Oct 1, 2022
44a2266
Update release notes
mwaskom Oct 1, 2022
0d16cb4
Allow marks to be withheld from legend
mwaskom Oct 1, 2022
0d7f264
Fix legend creation
mwaskom Oct 2, 2022
8fa321b
Make text tests compatibile with older matplotlibs
mwaskom Oct 2, 2022
c732871
Add simple test for objects namespace
mwaskom Oct 2, 2022
91cfe77
Add tests for text alignment mapping
mwaskom Oct 2, 2022
36a2091
Add Text offset property
mwaskom Oct 2, 2022
1a45ad8
Simplify offset property to use point units
mwaskom Oct 3, 2022
4c44609
Add Text API examples and update properties tutorial
mwaskom Oct 3, 2022
3ea116e
Update offset examples in Text API docs
mwaskom Oct 3, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix legend creation
  • Loading branch information
@mwaskom
mwaskom committed Oct 2, 2022
commit 0d7f264a79da7a8e65fe8420a98b59d5fc7a132b
2 changes: 1 addition & 1 deletion seaborn/_core/plot.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1569,7 +1569,7 @@ def _update_legend_contents(
artist = mark._legend_artist(variables, val, scales)
if artist is not None:
artists.append(artist)
if contents:
if artists:
contents.append((key, artists, labels))

self._legend_contents.extend(contents)
Expand Down