Skip to content

isValidKey using toArray() directly #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 26, 2015
Merged

isValidKey using toArray() directly #16

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a3d1ad9
isValidKey using toArray() directly
KKKas Apr 23, 2015
627085e
isValidKey() fix for PHP < 5.4
KKKas Apr 23, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
isValidKey using toArray() directly 
Now it doesn't need to use toArray()->array_keys->in_array, but just toArray() and isset[$key], which should be faster.
  • Loading branch information
@KKKas
KKKas committed Apr 23, 2015
commit a3d1ad9b14b5716fe50f23e68fccb7118b29d220
2 changes: 1 addition & 1 deletion src/Enum.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,7 +119,7 @@ public static function isValid($value)
*/
public static function isValidKey($key)
{
return in_array($key, self::keys(), true);
return isset(self::toArray()[$key]);
}

/**
Expand Down