Upgrade to Psalm 5

[rogervila]

Hi,

When upgrading to Psalm 5, there are some errors that have appeared:

ERROR: UnsafeGenericInstantiation - src/Enum.php:179:29 - Cannot safely instantiate generic class MyCLabs\Enum\Enum with "new static" as its generic parameters may be constrained in child classes. (see https://psalm.dev/269)
            $values[$key] = new static($value);


ERROR: UnsafeGenericInstantiation - src/Enum.php:300:54 - Cannot safely instantiate generic class MyCLabs\Enum\Enum with "new static" as its generic parameters may be constrained in child classes. (see https://psalm.dev/269)
            return self::$instances[$class][$name] = new static($array[$name]);


ERROR: ImpureMethodCall - src/Enum.php:313:7 - Cannot call an impure constructor from a pure context (see https://psalm.dev/203)
    #[\ReturnTypeWillChange]

I have silenced them as a first approach. We can fix them on this PR or create another one once this is one is merged.

[mnapoli]

Why this removal?

[rogervila]

Because of this error:

ERROR: ImpureMethodCall - src/Enum.php:313:7 - Cannot call an impure constructor from a pure context (see https://psalm.dev/203)
    #[\ReturnTypeWillChange]

We should either remove @psalm-pure or #[\ReturnTypeWillChange]

Since Enum's JSON serialization can be anything, We may keep the second one.

[mnapoli]

Thanks! Since this package still supports PHP 7.3 I'm not sure if we shouldn't require Psalm 4|5?

[peter279k]

According to the composer.json of latest Psalm version, it should require php-7.4 version at least.

[rogervila]

Thank you @peter279k, let me modify to support also v4

[mnapoli]

Thanks!