Skip to content

Prefix all function calls with a backspace #75

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 1, 2018
Merged

Prefix all function calls with a backspace #75

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
cad9c48
Prefix all function calls with a backspace
Jul 31, 2018
ec1d4fc
Replace function call with language construct (isset([]) evaluates to…
Jul 31, 2018
ca4a0a0
Add travis_retry to overcome transport failures in composer install
Jul 31, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Replace function call with language construct (isset([]) evaluates to… 
… true)
  • Loading branch information
Willem Stuursma committed Jul 31, 2018
commit ec1d4fc213648a1c36ab1f619e3461069b0a7d76
2 changes: 1 addition & 1 deletion src/Enum.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,7 +119,7 @@ public static function values()
public static function toArray()
{
$class = \get_called_class();
if (!\array_key_exists($class, static::$cache)) {
if (!isset(static::$cache[$class])) {
Copy link
Member

@mnapoli mnapoli Aug 1, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you sure this change doesn't introduce BC breaks?

Copy link
Contributor Author

@willemstuursma willemstuursma Aug 1, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. static::$cache can only be instances of array, for which isset returns the exact values as array_key_exists. The only difference between the two is their behaviour around null values.

$reflection = new \ReflectionClass($class);
static::$cache[$class] = $reflection->getConstants();
}
Expand Down