Skip to content

Set opportunity to create enum statically with null value #78

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 27, 2018
Merged

Set opportunity to create enum statically with null value #78

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
5e044e6
Set opportunity to create enum statically with null value
KartaviK Oct 25, 2018
0b720b9
Use array_key_exists() as an extra check
KartaviK Oct 25, 2018
7c858b2
Add miss back slash
KartaviK Oct 25, 2018
f8c4a11
Add tests for boolean enum
KartaviK Oct 25, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Set opportunity to create enum statically with null value
  • Loading branch information
@KartaviK
KartaviK committed Oct 25, 2018
commit 5e044e6635653ab2888551501426ba44385f18d1
2 changes: 1 addition & 1 deletion src/Enum.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -177,7 +177,7 @@ public static function search($value)
public static function __callStatic($name, $arguments)
{
$array = static::toArray();
if (isset($array[$name])) {
if (array_key_exists($name, $array)) {
return new static($array[$name]);
}

Expand Down
7 changes: 7 additions & 0 deletions tests/EnumTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -262,4 +262,11 @@ public function testJsonSerialize()
$this->assertJsonStringEqualsJsonString('""', json_encode(new EnumFixture(EnumFixture::PROBLEMATIC_EMPTY_STRING)));
$this->assertJsonStringEqualsJsonString('false', json_encode(new EnumFixture(EnumFixture::PROBLEMATIC_BOOLEAN_FALSE)));
}

public function testNullableEnum()
{
$this->assertNull(EnumFixture::PROBLEMATIC_NULL()->getValue());
$this->assertNull((new EnumFixture(EnumFixture::PROBLEMATIC_NULL))->getValue());
$this->assertNull((new EnumFixture(EnumFixture::PROBLEMATIC_NULL))->jsonSerialize());
}
}