Mysgw configure: Exit on illegal parameters #1519
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The user probably made a mistake. Let the user correct the mistake before continuing. Ref: mysensors#1518 Example output after this change: $ ./configure --my-transport=laser [SECTION] Detecting target machine. [OK] machine detected: SoC=unknown, Type=unknown, CPU=x86_64. [SECTION] Checking GPIO Sysfs. [WARNING] /sys/class/gpio/export not found. [SECTION] Detecting SPI driver. [WARNING] No supported SPI driver detected. Using SPIDEV. [SECTION] Gateway configuration. [OK] Type: ethernet. [ERROR] Invalid transport type laser. $ ./configure --my-mqtt-username=user [ERROR] Unknown option detected: --my-mqtt-username=user
mfalkvidd
force-pushed
the
configure-exit-on-bad-parameter
branch
from
28a4509 to
c185709
Compare
mfalkvidd
requested review from
henrikekblad,
marceloaqno,
scalz,
tbowmo,
tekka007 and
Yveaux
tekka007
pushed a commit
to tekka007/MySensors
that referenced
this pull request
Jul 25, 2022
The user probably made a mistake. Let the user correct the mistake before continuing. Ref: mysensors#1518 Example output after this change: $ ./configure --my-transport=laser [SECTION] Detecting target machine. [OK] machine detected: SoC=unknown, Type=unknown, CPU=x86_64. [SECTION] Checking GPIO Sysfs. [WARNING] /sys/class/gpio/export not found. [SECTION] Detecting SPI driver. [WARNING] No supported SPI driver detected. Using SPIDEV. [SECTION] Gateway configuration. [OK] Type: ethernet. [ERROR] Invalid transport type laser. $ ./configure --my-mqtt-username=user [ERROR] Unknown option detected: --my-mqtt-username=user
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The user probably made a mistake. Let the user correct the mistake
before continuing.
Ref: #1518
Example output after this change:
$ ./configure --my-transport=laser
[SECTION] Detecting target machine.
[OK] machine detected: SoC=unknown, Type=unknown, CPU=x86_64.
[SECTION] Checking GPIO Sysfs.
[WARNING] /sys/class/gpio/export not found.
[SECTION] Detecting SPI driver.
[WARNING] No supported SPI driver detected. Using SPIDEV.
[SECTION] Gateway configuration.
[OK] Type: ethernet.
[ERROR] Invalid transport type laser.
$ ./configure --my-mqtt-username=user
[ERROR] Unknown option detected: --my-mqtt-username=user