feat: improve provider fetching #124
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Integrates libp2p/rust-libp2p#2712 to fetch providers more quickly. For widely available providers this reduces the fetch time considerably.
Arqu
previously approved these changes
Jun 16, 2022
Collaborator
Arqu
left a comment
Arqu
left a comment
There was a problem hiding this comment.
Looking forward to this one, if it just resolves most of the 0 provider requests we're ~10% better off than before.
improve bitswap connection handling & connection parameters
Collaborator
|
Tested locally, after some warmup time/requests, things seem a lot better than before. |
dignifiedquire
pushed a commit
that referenced
this pull request
Feb 20, 2023
This makes it so that the provider is allowed to close the connection after a transfer is completed, without the getter resulting in an error. It modifies the provider to only emit the transfer completed once the data has actually reached the client.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Integrates libp2p/rust-libp2p#2712 to fetch providers more quickly. For widely available providers this reduces the fetch time considerably.