feat(iroh-relay): allow for extension of RelayMaps
#3575
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Documentation for this PR has been generated and is available at: https://n0-computer.github.io/iroh/pr/3575/docs/iroh/ Last updated: 2025-10-23T16:26:55Z |
Frando
approved these changes
Oct 23, 2025
Comment on lines
+116
to
+120
| pub fn extend(&self, other: &RelayMap) { | ||
| let mut a = self.relays.write().expect("poisoned"); | ||
| let b = other.relays.read().expect("poisoned"); | ||
| a.extend(b.iter().map(|(a, b)| (a.clone(), b.clone()))); | ||
| } |
Contributor
There was a problem hiding this comment.
This should be impl Extend for RelayMap IMO.
Also: Why is there panicing expect inside of this function? This is not what a user expects from the documentation of the whole type!
Contributor
There was a problem hiding this comment.
After some discussion on your discord tho, using the Extend trait does not seem possible because of how the types are designed here.
And the std RwLock cannot easily be replaced by a tokio one 😢
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.