fix(tests): Also run the tests in isolation in the default profile #3664
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This means these tests also work when nextest run locally.
dignifiedquire
approved these changes
Nov 14, 2025
|
Documentation for this PR has been generated and is available at: https://n0-computer.github.io/iroh/pr/3664/docs/iroh/ Last updated: 2025-11-14T12:10:53Z |
Contributor
Author
|
Meh, merging early. @Arqu and @divagant-martian please still review. We can always fixup. |
Arqu
reviewed
Nov 14, 2025
Collaborator
Arqu
left a comment
Arqu
left a comment
There was a problem hiding this comment.
Hmmm, think we used to always run with the ci profile in CI so things were fine. Unsure when stuff changed. This is fine though.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This means these tests also work when nextest run locally.
Breaking Changes
Notes & open questions
I'm not sure why this wasn't done when the ci profile override was
chosen. What am I missing?
Change checklist