refactor(iroh): Spawn RemoteStateActor in JoinSet and remove guarded_channel.rs
#3681
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ix-remote-state-actor-loop
…send_datagram` (#3678) Intended for merging into #3676 - Makes `idle_timeout` always be a `time::Sleep` that is `.reset` once there is any activity. I find this much easier to reason about. - Fixes a bug where `handle_msg_send_datagram` short-circuits when sending on one path fails. Instead, it should *try* all paths, even if some of them fail.
…ix-remote-state-actor-loop
matheus23
changed the base branch from
feat-multipath
to
Frando/mp-fix-remote-state-actor-loop
matheus23
force-pushed
the
matheus23/no-guarded-channel
branch
from
5c66034 to
de05f27
Compare
|
Documentation for this PR has been generated and is available at: https://n0-computer.github.io/iroh/pr/3681/docs/iroh/ Last updated: 2025-11-20T10:41:01Z |
11 tasks
matheus23
force-pushed
the
matheus23/no-guarded-channel
branch
from
de05f27 to
4c4d11d
Compare
Member
Author
|
This PR has the problem that we only run the Also: The |
Base automatically changed from
Frando/mp-fix-remote-state-actor-loop
to
feat-multipath
November 20, 2025 14:33
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
guarded_channel.rsRemoteMap, which will immediately spawn a newRemoteStateActorin case it missed some messages during shutdown.RemoteStateActorin aJoinSetthat's held in aMutexinside theRemoteMap(effectively owned by the magic socket).Notes & open questions
I think it's good to look at this right now, but some considerations/TODOs:
RemoteMap. Maybe only themagicsock::Actorshould own theJoinSet, and theRemoteMapshouldn't actually store it itself.RemoteStateActor::runis the right way to do this.Change checklist