Skip to content

refactor: add qlog factory, move group_id to common_fields #218

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Frando merged 7 commits into from
Dec 5, 2025
Merged

refactor: add qlog factory, move group_id to common_fields #218

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
c3cfcec
refactor: add qlog factory, move group_id to common_fields
Frando Dec 4, 2025
0942460
docs: improve
Frando Dec 5, 2025
451d3e7
chore: clippy
Frando Dec 5, 2025
f018fb5
fixup
Frando Dec 5, 2025
a02f4b2
feat: add QlogFileFactory and util methods on TransportConfig
Frando Dec 5, 2025
d659f71
feat: reexport from quinn
Frando Dec 5, 2025
47880d5
chore: clippy
Frando Dec 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
chore: clippy
  • Loading branch information
@Frando
Frando committed Dec 5, 2025
commit 451d3e765e47825f952d217aad8a824cad85a4bb
2 changes: 1 addition & 1 deletion perf/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,7 +128,7 @@ impl CommonOpt {

#[cfg(feature = "qlog")]
if let Some(qlog_dir) = &self.qlog_dir {
std::fs::create_dir_all(&qlog_dir)?;
std::fs::create_dir_all(qlog_dir)?;
struct Factory {
dir: PathBuf,
name: String,
Expand Down
3 changes: 1 addition & 2 deletions quinn-proto/src/config/transport.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -492,8 +492,7 @@ impl TransportConfig {
if let Some(config) = self
.qlog_factory
.as_ref()
.map(|factory| factory.for_connection(side, remote, initial_dst_cid, now))
.flatten()
.and_then(|factory| factory.for_connection(side, remote, initial_dst_cid, now))
{
QlogSink::new(config, initial_dst_cid, side, now)
} else {
Expand Down
6 changes: 4 additions & 2 deletions quinn-proto/src/connection/qlog.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,8 +66,10 @@ impl QlogStream {
flow: None,
};

let mut common_fields = CommonFields::default();
common_fields.group_id = Some(initial_dst_cid.to_string());
let common_fields = CommonFields {
group_id: Some(initial_dst_cid.to_string()),
..Default::default()
};

let trace = qlog::TraceSeq::new(
config.title.clone(),
Expand Down