fix: Add cleanup for e2e dev (no-changelog) #23220
Merged
+67
−21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shortstacked
approved these changes
Dec 15, 2025
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
|
E2E Tests: n8n tests passed after 5m 23.9s Run Details
This message was posted automatically by
currents.dev | Integration Settings
|
This comment has been minimized.
This comment has been minimized.
|
Got released with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This pull request enhances the Playwright E2E testing setup by improving the management of web servers and test environment teardown. The most significant changes include introducing a global teardown script to clean up test processes, refactoring how web servers are started and reused, and updating related scripts for consistency and reliability.
Test environment management improvements:
global-teardown.tsscript that kills any processes running on ports 5678 and 8080 after tests finish, ensuring a clean test environment. (packages/testing/playwright/global-teardown.ts)packages/testing/playwright/playwright.config.ts)Web server and test script refactoring:
webServerarray, allowing both backend and frontend servers to be started and reused as needed. (packages/testing/playwright/playwright.config.ts) [1] [2]packages/testing/playwright/playwright.config.ts) [1] [2]dev:fe:e2escript frompackage.jsonto avoid confusion and redundancy. (package.json)Related Linear tickets, Github issues, and Community forum posts
https://linear.app/n8n/issue/CAT-1890/allow-running-playwright-e2e-in-dev-mode-using-vite-devserver
Review / Merge checklist
release/backport(if the PR is an urgent fix that needs to be backported)