feat: Support dynamic credentials in oauth refresh #23225
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
n8n-assistant
bot
added
core
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
This comment has been minimized.
This comment has been minimized.
|
E2E Tests: n8n tests passed after 8m 34.3s Run Details
Groups
This message was posted automatically by
currents.dev | Integration Settings
|
afitzek
reviewed
Dec 15, 2025
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
2 issues found across 3 files
Prompt for AI agents (all 2 issues)
Check if these issues are valid — if so, understand the root cause of each and fix them.
<file name="packages/cli/src/credentials-helper.ts">
<violation number="1" location="packages/cli/src/credentials-helper.ts:549">
P2: Rule violated: **Prefer Typeguards over Type casting**
Unnecessary type cast using `as`. The `toCredentialContext` function already returns a properly typed `ICredentialContext`. Instead of casting, use the `ICredentialContext` type directly or import and use `ICredentialContextV1` from 'n8n-workflow' if the specific V1 shape is needed.</violation>
</file>
<file name="packages/core/src/execution-engine/node-execution-context/utils/request-helper-functions.ts">
<violation number="1" location="packages/core/src/execution-engine/node-execution-context/utils/request-helper-functions.ts:1633">
P2: Rule violated: **Prefer Typeguards over Type casting**
Use a type guard instead of `as` for type narrowing. Since `contentBody` has type `Exclude<IN8nHttpResponse, Buffer>`, using `contentBody as string` violates the rule against using `as` for type narrowing. Consider adding a type guard check or refactoring the variable declaration to have the correct type from assignment.</violation>
</file>
Reply to cubic to teach it or ask questions. Re-run a review with @cubic-dev-ai review this PR
packages/core/src/execution-engine/node-execution-context/utils/request-helper-functions.ts
Outdated
Show resolved
Hide resolved
guillaumejacquart
approved these changes
Dec 15, 2025
Contributor
guillaumejacquart
left a comment
guillaumejacquart
left a comment
There was a problem hiding this comment.
Looks good to me
guillaumejacquart
pushed a commit
that referenced
this pull request
Dec 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR allows dynamic credentials resolvers to be used for storing a refreshed token assuming the credential is resolver capable and has a resolver id.
This allows refreshing of tokens, and also avoids the risk of a dynamic credential overwriting static credential data
Related Linear tickets, Github issues, and Community forum posts
PAY-4235
PAY-4317
Review / Merge checklist
release/backport(if the PR is an urgent fix that needs to be backported)