rework to support multiple concurrent instances #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: nachoparker <[email protected]>
This was referenced Jun 28, 2019
Owner
Author
|
Sent it for review I'll block comments here since any conversation should happen in the official repo |
Repository owner
locked and limited conversation to collaborators
Jul 3, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and goals
See nachoparker/server#1
Changes
This PR is a PoC which allows multiple concurrent executions of the preview generator in order to speed up the process by using more cores.
Ideally we would use a PHP native method for creating theads but this does not have good distribution support yet (see next section).
Results
See nachoparker/server#1 for details
Future work
pthreadsorparallelonce there are ZTS PHP packages available (link link) instead of relying on an external script that launches several processes in parallel.Signed-off-by: nachoparker [email protected]