Skip to content

fix: webhook validate logic in kubebuilder version 3.11.0 #27

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 56 commits into from
Nov 23, 2023
Merged

fix: webhook validate logic in kubebuilder version 3.11.0 #27

merged 56 commits into from
Nov 23, 2023

Conversation

@nakamasato
Copy link
Owner

@nakamasato nakamasato commented Nov 23, 2023 •
edited
Loading

why

webhook validate functions were not properly updated in #21

when changing the interface

what

  • fix the .upgrade-version.sh error -> (admission.Warnings, error)
  • revert the change in chore: update kubebuilder version to 3.12.0 #22 
    - gsed -i 's/#- patches/- path: patches/g' config/crd/kustomization.yaml
+ gsed -i 's/#- path: patches/- path: patches/g' config/crd/kustomization.yaml

ref

@nakamasato
fix
f456583
@nakamasato
Remove all files to upgrade versions (v3.11.0)
af24d22
@nakamasato
[kubebuilder] Init project
2c69468
@nakamasato
[kubebuilder] Create API Password (Controller & Resource)
4c5d65f
@nakamasato
[Controller] Add log in Reconcile function
ca025c9
@nakamasato
[API] Remove Foo field from custom resource Password
1211390
@nakamasato
[Controller] Fetch Password object
f72dab8
@nakamasato
[Controller] Create Secret object if not exists
ba7b132
@nakamasato
[Controller] Clean up Secret when Password is deleted
e0abbf9
@nakamasato
[Controller] Generate random password
c564da4
@nakamasato
[API&Controller] Make password configurable with CRD fields
9982d43
@nakamasato
[API&Controller] Add Password Status
b420d02
@nakamasato
[API] Add AdditionalPrinterColumns
41b960a
@nakamasato
[kubebuilder] Create validating admission webhook
c8dab32
@nakamasato
Remove all files to upgrade versions (v3.11.0)
b58b9ac
@nakamasato
[kubebuilder] Init project
424ce2a
@nakamasato
[kubebuilder] Create API Password (Controller & Resource)
a8517b5
@nakamasato
[Controller] Add log in Reconcile function
930b961
@nakamasato
[API] Remove Foo field from custom resource Password
22d44a4
@nakamasato
[Controller] Fetch Password object
8365ee9
@nakamasato
[Controller] Create Secret object if not exists
a78ec31
@nakamasato
[Controller] Clean up Secret when Password is deleted
6c60776
@nakamasato
[Controller] Generate random password
58d1088
@nakamasato
[API&Controller] Make password configurable with CRD fields
2da6ed4
@nakamasato
[API&Controller] Add Password Status
4bff4d2
@nakamasato
[API] Add AdditionalPrinterColumns
622c1d2
@nakamasato
[kubebuilder] Create validating admission webhook
2d708b4
@nakamasato
[API] Implement validating admission webhook
b9e2b25
@nakamasato
Update README
301e7f7
@nakamasato nakamasato mentioned this pull request Nov 23, 2023
Merged
@nakamasato
[API] Remove Foo field from custom resource Password
56d078b
@nakamasato
[Controller] Fetch Password object
2af3aac
@nakamasato
[Controller] Create Secret object if not exists
78eb590
@nakamasato
[Controller] Clean up Secret when Password is deleted
899d5e4
@nakamasato
[Controller] Generate random password
8df5230
@nakamasato
[API&Controller] Make password configurable with CRD fields
6b865bd
@nakamasato
[API&Controller] Add Password Status
75e95b0
@nakamasato
[API] Add AdditionalPrinterColumns
a717347
@nakamasato
[kubebuilder] Create validating admission webhook
43d8e59
@nakamasato
Remove all files to upgrade versions (v3.11.0)
1f43e3d
@nakamasato
[kubebuilder] Init project
8b6f80d
@nakamasato
[kubebuilder] Create API Password (Controller & Resource)
afbc0c3
@nakamasato
[Controller] Add log in Reconcile function
b290f1c
@nakamasato
[API] Remove Foo field from custom resource Password
1855edd
@nakamasato
[Controller] Fetch Password object
fae7d6d
@nakamasato
[Controller] Create Secret object if not exists
37f191c
@nakamasato
[Controller] Clean up Secret when Password is deleted
94ef32a
@nakamasato
[Controller] Generate random password
9ea7a1b
@nakamasato
[API&Controller] Make password configurable with CRD fields
f56bf47
@nakamasato
[API&Controller] Add Password Status
d2c1f28
@nakamasato
[API] Add AdditionalPrinterColumns
3964471
@nakamasato
[kubebuilder] Create validating admission webhook
0b098f2
@nakamasato
[API] Implement validating admission webhook
9eb7dc3
@nakamasato nakamasato marked this pull request as ready for review November 23, 2023 07:57
@nakamasato nakamasato merged commit 874985c into main Nov 23, 2023
@nakamasato nakamasato deleted the fix-kubebuilder-version-3.11.0 branch November 23, 2023 07:58
@github-actions
Copy link

github-actions bot commented Nov 23, 2023

PR has been merged. we're publishing a new release! (Thu Nov 23 2023 07:58:58 GMT+0000 (Coordinated Universal Time))

@github-actions
Copy link

github-actions bot commented Nov 23, 2023

New release v0.0.10 has been published! (Thu Nov 23 2023 07:59:03 GMT+0000 (Coordinated Universal Time))

@nakamasato nakamasato mentioned this pull request Nov 23, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

release

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@nakamasato